Skip to content

Commit 7f4b2a0

Browse files
committed
Add missing docs explaining ignore
1 parent b327bde commit 7f4b2a0

File tree

12 files changed

+201
-156
lines changed

12 files changed

+201
-156
lines changed

demo_app/integration_test/auto_resize_test.dart

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ void main() {
2424
});
2525

2626
final webViewTestCases = ValueVariant(const {
27-
WebViewTestCase(0.5, false),
28-
WebViewTestCase(1.0, false),
29-
WebViewTestCase(2.0, false),
30-
WebViewTestCase(1.0, true),
27+
WebViewTestCase(input: 0.5, issue375: false),
28+
WebViewTestCase(input: 1.0, issue375: false),
29+
WebViewTestCase(input: 2.0, issue375: false),
30+
WebViewTestCase(input: 1.0, issue375: true),
3131
});
3232

3333
patrolTest(
@@ -64,8 +64,10 @@ class WebViewTestCase {
6464
final double input;
6565
final bool issue375;
6666

67-
// ignore: avoid_positional_boolean_parameters
68-
const WebViewTestCase(this.input, this.issue375);
67+
const WebViewTestCase({
68+
required this.input,
69+
required this.issue375,
70+
});
6971

7072
Future<_AspectRatioTest> run(PatrolIntegrationTester $) async {
7173
final html = '''

packages/core/lib/src/core_legacy.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// intentionally uses deprecated members for backwards compatibility
12
// ignore_for_file: deprecated_member_use_from_same_package
23

34
import 'package:flutter/widgets.dart';

packages/core/lib/src/internal/core_build_tree.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,7 @@ class _LockableDeclarations extends LockableList<css.Declaration> {
450450

451451
class _WidgetPlaceholderDefault extends StatelessWidget
452452
implements
453+
// internal implementation detail of our own placeholder
453454
// ignore: avoid_implementing_value_types
454455
WidgetPlaceholder {
455456
const _WidgetPlaceholderDefault();

0 commit comments

Comments
 (0)