Skip to content

Commit ad93a2a

Browse files
authored
Change column width calculation logic (#747)
Previously, the viewport width is divided between available columns. If some cell has width inline styling, it will be applied directly which may cause weird rendering issue (see #733). In this PR, the cell intrinsic width is taken into account but not used directly to make sure table contents are all visible. Because of this logic, table cells may be rendered outside of the reported canvas size. Wrapping `HtmlTable` within some `ClipRect` should help if that behavior is undesired. Related to #531
1 parent cedfa18 commit ad93a2a

34 files changed

+628
-520
lines changed

demo_app/pubspec.lock

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -209,14 +209,14 @@ packages:
209209
path: "../packages/enhanced"
210210
relative: true
211211
source: path
212-
version: "0.8.5"
212+
version: "0.9.0+1"
213213
flutter_widget_from_html_core:
214214
dependency: "direct main"
215215
description:
216216
path: "../packages/core"
217217
relative: true
218218
source: path
219-
version: "0.8.5+3"
219+
version: "0.9.0+1"
220220
frontend_server_client:
221221
dependency: transitive
222222
description:
@@ -235,28 +235,28 @@ packages:
235235
path: "../packages/fwfh_cached_network_image"
236236
relative: true
237237
source: path
238-
version: "0.7.0+2"
238+
version: "0.7.0+3"
239239
fwfh_chewie:
240240
dependency: "direct main"
241241
description:
242242
path: "../packages/fwfh_chewie"
243243
relative: true
244244
source: path
245-
version: "0.7.0+1"
245+
version: "0.7.0+3"
246246
fwfh_just_audio:
247247
dependency: "direct overridden"
248248
description:
249249
path: "../packages/fwfh_just_audio"
250250
relative: true
251251
source: path
252-
version: "0.6.2+2"
252+
version: "0.9.0"
253253
fwfh_svg:
254254
dependency: "direct overridden"
255255
description:
256256
path: "../packages/fwfh_svg"
257257
relative: true
258258
source: path
259-
version: "0.7.2"
259+
version: "0.7.2+1"
260260
fwfh_text_style:
261261
dependency: "direct overridden"
262262
description:
@@ -270,14 +270,14 @@ packages:
270270
path: "../packages/fwfh_url_launcher"
271271
relative: true
272272
source: path
273-
version: "0.6.1+3"
273+
version: "0.9.0"
274274
fwfh_webview:
275275
dependency: "direct main"
276276
description:
277277
path: "../packages/fwfh_webview"
278278
relative: true
279279
source: path
280-
version: "0.6.2+3"
280+
version: "0.6.2+5"
281281
glob:
282282
dependency: transitive
283283
description:
-16 Bytes
Loading
-8 Bytes
Loading
24.6 KB
Loading
-25 Bytes
Loading
-2.05 KB
Loading
-3.8 KB
Loading
-412 Bytes
Loading

demo_app/test/table/colspan.png

42 Bytes
Loading

demo_app/test/table/height_1px.png

4.38 KB
Loading

0 commit comments

Comments
 (0)