Skip to content

Commit ae630ec

Browse files
authored
Fix SonarCloud code smells (#1433)
1 parent 8c14f9c commit ae630ec

File tree

1 file changed

+22
-12
lines changed

1 file changed

+22
-12
lines changed

packages/core/lib/src/internal/parser/color.dart

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,17 @@ CssColor? tryParseColor(css.Expression? expression) {
9090
return null;
9191
}
9292

93-
double? _parseColorAlpha(css.Expression v) => (v is css.NumberTerm
94-
? v.number.toDouble()
95-
: v is css.PercentageTerm
96-
? v.valueAsDouble
97-
: null)
98-
?.clamp(0.0, 1.0);
93+
double? _parseColorAlpha(css.Expression expression) {
94+
final double? value;
95+
if (expression is css.NumberTerm) {
96+
value = expression.number.toDouble();
97+
} else if (expression is css.PercentageTerm) {
98+
value = expression.valueAsDouble;
99+
} else {
100+
value = null;
101+
}
102+
return value?.clamp(0, 1);
103+
}
99104

100105
double _parseColorHue(num number, [int? unit]) {
101106
final v = number is double ? number : number.toDouble();
@@ -122,12 +127,17 @@ double _parseColorHue(num number, [int? unit]) {
122127
return deg % 360;
123128
}
124129

125-
int? _parseColorRgbElement(css.Expression v) => (v is css.NumberTerm
126-
? v.number.ceil()
127-
: v is css.PercentageTerm
128-
? (v.valueAsDouble * 255.0).ceil()
129-
: null)
130-
?.clamp(0, 255);
130+
int? _parseColorRgbElement(css.Expression expression) {
131+
final int? value;
132+
if (expression is css.NumberTerm) {
133+
value = expression.number.ceil();
134+
} else if (expression is css.PercentageTerm) {
135+
value = (expression.valueAsDouble * 255.0).ceil();
136+
} else {
137+
value = null;
138+
}
139+
return value?.clamp(0, 255);
140+
}
131141

132142
String _x2(String value) {
133143
final sb = StringBuffer();

0 commit comments

Comments
 (0)