Skip to content

Commit d8f9bf0

Browse files
authored
Fix text-align: center inside tables (#1451)
Also: * Switch to use sizing hints * Register block op for table cells * Take min width into account when render table / table cell
1 parent a8a1741 commit d8f9bf0

File tree

15 files changed

+128
-256
lines changed

15 files changed

+128
-256
lines changed
0 Bytes
Loading
-533 Bytes
Loading

demo_app/test/table/height_1px.png

-4.68 KB
Binary file not shown.

demo_app/test/table/row_color.png

-24 Bytes
Loading
3.99 KB
Loading
3.89 KB
Loading
6.06 KB
Loading
-3 Bytes
Loading
1 Byte
Loading

packages/core/lib/src/core_widget_factory.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,7 +1048,7 @@ class WidgetFactory extends WidgetFactoryResetter with AnchorWidgetFactory {
10481048
case kCssMinHeight:
10491049
case kCssMinWidth:
10501050
case kCssWidth:
1051-
StyleSizing.registerSizingOp(this, tree);
1051+
StyleSizing.registerSizingOp(tree);
10521052

10531053
case kCssLineHeight:
10541054
final value = style.value;
@@ -1114,13 +1114,13 @@ class WidgetFactory extends WidgetFactoryResetter with AnchorWidgetFactory {
11141114

11151115
/// Parses display inline style.
11161116
void parseStyleDisplay(BuildTree tree, String? value) {
1117-
StyleSizing.maybeRegisterChildOp(this, tree);
1117+
StyleSizing.maybeRegisterChildOp(tree);
11181118

11191119
switch (value) {
11201120
case kCssDisplayFlex:
11211121
tree.register(_styleDisplayFlex ??= StyleDisplayFlex(this).buildOp);
11221122
case kCssDisplayBlock:
1123-
StyleSizing.registerBlockOp(this, tree);
1123+
StyleSizing.registerBlockOp(tree);
11241124
case kCssDisplayInlineBlock:
11251125
tree.register(displayInlineBlock);
11261126
case kCssDisplayNone:

0 commit comments

Comments
 (0)