Use our own HtmlLayoutBuilder to avoid test failures

Author: daohoangson

demo_app/devtools_options.yaml

@@ -0,0 +1,3 @@
+description: This file stores settings for Dart & Flutter DevTools.
+documentation: https://docs.flutter.dev/tools/devtools/extensions#configure-extension-enablement-states
+extensions:

packages/core/lib/src/core_helpers.dart

@@ -15,6 +15,7 @@ export 'widgets/css_sizing.dart';
 export 'widgets/horizontal_margin.dart';
 export 'widgets/html_details.dart';
 export 'widgets/html_flex.dart';
+export 'widgets/html_layout_builder.dart';
 export 'widgets/html_list_item.dart';
 export 'widgets/html_list_marker.dart';
 export 'widgets/html_ruby.dart';

packages/core/lib/src/core_widget_factory.dart

@@ -233,7 +233,7 @@ class WidgetFactory extends WidgetFactoryResetter with AnchorWidgetFactory {
     TextBaseline textBaseline = TextBaseline.alphabetic,
     TextDirection textDirection = TextDirection.ltr,
   }) {
-    return LayoutBuilder(
+    return HtmlLayoutBuilder(
       builder: (_, bc) {
         Widget built = HtmlFlex(
           crossAxisAlignment: crossAxisAlignment,

packages/core/lib/src/internal/ops/tag_table.dart

@@ -83,7 +83,7 @@ class TagTable {
         ? tryParseCssLength(borderSpacingExpression)
         : null;
 
-    final layoutBuilder = LayoutBuilder(
+    final layoutBuilder = HtmlLayoutBuilder(
       builder: (context, bc) {
         final resolved = tableTree.inheritanceResolvers.resolve(context);
         Widget built = ValignBaselineContainer(

packages/core/lib/src/widgets/html_layout_builder.dart

@@ -0,0 +1,85 @@
+import 'package:flutter/rendering.dart';
+import 'package:flutter/widgets.dart';
+
+/// Builds a widget tree that can depend on the parent widget's size.
+///
+/// The difference from [LayoutBuilder] is that this widget does not
+/// perform any assertions during the build phase.
+class HtmlLayoutBuilder extends ConstrainedLayoutBuilder<BoxConstraints> {
+  /// Creates a widget that defers its building until layout.
+  const HtmlLayoutBuilder({super.key, required super.builder});
+
+  @override
+  RenderAbstractLayoutBuilderMixin<BoxConstraints, RenderBox>
+      createRenderObject(
+    BuildContext context,
+  ) =>
+          _RenderLayoutBuilder();
+}
+
+class _RenderLayoutBuilder extends RenderBox
+    with
+        RenderObjectWithChildMixin<RenderBox>,
+        RenderObjectWithLayoutCallbackMixin,
+        RenderAbstractLayoutBuilderMixin<BoxConstraints, RenderBox> {
+  @override
+  double? computeDistanceToActualBaseline(TextBaseline baseline) {
+    return child?.getDistanceToActualBaseline(baseline) ??
+        super.computeDistanceToActualBaseline(baseline);
+  }
+
+  @override
+  double? computeDryBaseline(
+      BoxConstraints constraints, TextBaseline baseline) {
+    return null;
+  }
+
+  @override
+  Size computeDryLayout(BoxConstraints constraints) {
+    return Size.zero;
+  }
+
+  @override
+  double computeMaxIntrinsicHeight(double width) {
+    return 0.0;
+  }
+
+  @override
+  double computeMaxIntrinsicWidth(double height) {
+    return 0.0;
+  }
+
+  @override
+  double computeMinIntrinsicHeight(double width) {
+    return 0.0;
+  }
+
+  @override
+  double computeMinIntrinsicWidth(double height) {
+    return 0.0;
+  }
+
+  @override
+  bool hitTestChildren(BoxHitTestResult result, {required Offset position}) {
+    return child?.hitTest(result, position: position) ?? false;
+  }
+
+  @override
+  void paint(PaintingContext context, Offset offset) {
+    if (child != null) {
+      context.paintChild(child!, offset);
+    }
+  }
+
+  @override
+  void performLayout() {
+    final constraints = this.constraints;
+    runLayoutCallback();
+    if (child != null) {
+      child!.layout(constraints, parentUsesSize: true);
+      size = constraints.constrain(child!.size);
+    } else {
+      size = constraints.biggest;
+    }
+  }
+}

packages/core/test/_.dart

@@ -607,15 +607,16 @@ class Explainer {
       return _widget(widget.builder(context));
     }
 
-    if (widget is LayoutBuilder) {
+    if (widget is LayoutBuilder ||
+        widget.runtimeType.toString() == 'HtmlLayoutBuilder') {
       return _widget(
-        widget.builder(
+        (widget as dynamic).builder(
           context,
           BoxConstraints.loose(
             TestWidgetsFlutterBinding
                 .instance.platformDispatcher.implicitView!.physicalSize,
           ),
-        ),
+        ) as Widget,
       );
     }