diff --git a/demo_app/lib/screens/img_file.dart b/demo_app/lib/screens/img_file.dart index e05e87d41..fce52e817 100644 --- a/demo_app/lib/screens/img_file.dart +++ b/demo_app/lib/screens/img_file.dart @@ -61,7 +61,7 @@ class _ImgFileState extends State<_ImgFileTab> { } @override - Widget build(BuildContext _) => AnimatedBuilder( + Widget build(BuildContext context) => AnimatedBuilder( animation: status, builder: (_, __) { switch (status.value) { diff --git a/demo_app/lib/screens/wordpress.dart b/demo_app/lib/screens/wordpress.dart index 60d039fd1..d10418b59 100644 --- a/demo_app/lib/screens/wordpress.dart +++ b/demo_app/lib/screens/wordpress.dart @@ -42,7 +42,7 @@ class PostsScreen extends StatelessWidget { const PostsScreen(this.domain, {super.key, this.title}); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( appBar: AppBar(title: Text(title ?? domain)), body: _PostsList('https://$domain/wp-json/wp/v2/posts?_embed'), ); diff --git a/packages/core/lib/src/internal/ops/style_text_align.dart b/packages/core/lib/src/internal/ops/style_text_align.dart index f7aecb1e4..8c08a6409 100644 --- a/packages/core/lib/src/internal/ops/style_text_align.dart +++ b/packages/core/lib/src/internal/ops/style_text_align.dart @@ -23,7 +23,7 @@ extension StyleTextAlign on WidgetFactory { priority: Early.cssTextAlign, ); - static Widget _center(BuildContext _, Widget child) => + static Widget _center(BuildContext context, Widget child) => Center(heightFactor: 1.0, child: child); static BuildTree _onParsed(BuildTree tree) { diff --git a/packages/core/lib/src/widgets/css_sizing.dart b/packages/core/lib/src/widgets/css_sizing.dart index 57dcf4da1..8e33dbc8c 100644 --- a/packages/core/lib/src/widgets/css_sizing.dart +++ b/packages/core/lib/src/widgets/css_sizing.dart @@ -12,11 +12,11 @@ class CssBlock extends SingleChildRenderObjectWidget { const CssBlock({super.child, super.key}); @override - RenderObject createRenderObject(BuildContext _) => + RenderObject createRenderObject(BuildContext context) => _RenderCssSizing(preferredWidth: const CssSizingValue.percentage(100)); @override - void updateRenderObject(BuildContext _, RenderObject renderObject) => + void updateRenderObject(BuildContext context, RenderObject renderObject) => (renderObject as _RenderCssSizing).setPreferredSize( null, const CssSizingValue.percentage(100), diff --git a/packages/core/lib/src/widgets/html_list_item.dart b/packages/core/lib/src/widgets/html_list_item.dart index 185a53583..d9c8e2e97 100644 --- a/packages/core/lib/src/widgets/html_list_item.dart +++ b/packages/core/lib/src/widgets/html_list_item.dart @@ -24,7 +24,7 @@ class HtmlListItem extends MultiChildRenderObjectWidget { ); @override - RenderObject createRenderObject(BuildContext _) => + RenderObject createRenderObject(BuildContext context) => _ListItemRenderObject(textDirection: textDirection); @override @@ -34,7 +34,7 @@ class HtmlListItem extends MultiChildRenderObjectWidget { } @override - void updateRenderObject(BuildContext _, RenderObject renderObject) => + void updateRenderObject(BuildContext context, RenderObject renderObject) => (renderObject as _ListItemRenderObject).textDirection = textDirection; } diff --git a/packages/core/lib/src/widgets/html_list_marker.dart b/packages/core/lib/src/widgets/html_list_marker.dart index 3b37f2a0a..b3211a5f1 100644 --- a/packages/core/lib/src/widgets/html_list_marker.dart +++ b/packages/core/lib/src/widgets/html_list_marker.dart @@ -33,7 +33,7 @@ class HtmlListMarker extends LeafRenderObjectWidget { : markerType = HtmlListMarkerType.square; @override - RenderObject createRenderObject(BuildContext _) => + RenderObject createRenderObject(BuildContext context) => _ListMarkerRenderObject(markerType, textStyle); @override @@ -44,7 +44,7 @@ class HtmlListMarker extends LeafRenderObjectWidget { } @override - void updateRenderObject(BuildContext _, RenderObject renderObject) { + void updateRenderObject(BuildContext context, RenderObject renderObject) { (renderObject as _ListMarkerRenderObject) ..markerType = markerType ..textStyle = textStyle; diff --git a/packages/core/lib/src/widgets/html_ruby.dart b/packages/core/lib/src/widgets/html_ruby.dart index dd37a3371..34f5caff9 100644 --- a/packages/core/lib/src/widgets/html_ruby.dart +++ b/packages/core/lib/src/widgets/html_ruby.dart @@ -18,7 +18,7 @@ class HtmlRuby extends MultiChildRenderObjectWidget { ); @override - RenderObject createRenderObject(BuildContext _) => _RubyRenderObject(); + RenderObject createRenderObject(BuildContext context) => _RubyRenderObject(); } class _RubyParentData extends ContainerBoxParentData {} diff --git a/packages/core/lib/src/widgets/html_table.dart b/packages/core/lib/src/widgets/html_table.dart index 7351b7f45..6cc21d143 100644 --- a/packages/core/lib/src/widgets/html_table.dart +++ b/packages/core/lib/src/widgets/html_table.dart @@ -41,7 +41,7 @@ class HtmlTable extends MultiChildRenderObjectWidget { }); @override - RenderObject createRenderObject(BuildContext _) => _TableRenderObject( + RenderObject createRenderObject(BuildContext context) => _TableRenderObject( border, textDirection, borderCollapse: borderCollapse, @@ -74,7 +74,7 @@ class HtmlTable extends MultiChildRenderObjectWidget { } @override - void updateRenderObject(BuildContext _, RenderObject renderObject) { + void updateRenderObject(BuildContext context, RenderObject renderObject) { (renderObject as _TableRenderObject) ..setBorder(border) ..setBorderCollapse(borderCollapse) diff --git a/packages/core/test/_.dart b/packages/core/test/_.dart index 9b62eff9a..6638200be 100644 --- a/packages/core/test/_.dart +++ b/packages/core/test/_.dart @@ -897,7 +897,7 @@ class HitTestApp extends StatelessWidget { const HitTestApp({required this.html, super.key, required this.list}); @override - Widget build(BuildContext _) => MaterialApp( + Widget build(BuildContext context) => MaterialApp( home: Scaffold( body: HtmlWidget( html, diff --git a/packages/core/test/anchor_test.dart b/packages/core/test/anchor_test.dart index 41366296e..740831bdf 100644 --- a/packages/core/test/anchor_test.dart +++ b/packages/core/test/anchor_test.dart @@ -462,7 +462,7 @@ class _ColumnTestApp extends StatelessWidget { }); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( body: SingleChildScrollView( child: Column( children: [ @@ -485,7 +485,7 @@ class _ListViewTestApp extends StatelessWidget { const _ListViewTestApp({this.html}); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( body: HtmlWidget( html ?? htmlDefault, factoryBuilder: () => _WidgetFactory(), @@ -501,7 +501,7 @@ class _SliverListTestApp extends StatelessWidget { const _SliverListTestApp({this.keyBottom}); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( body: CustomScrollView( cacheExtent: 0, slivers: [ diff --git a/packages/core/test/core_config_test.dart b/packages/core/test/core_config_test.dart index b0ed61268..878192262 100644 --- a/packages/core/test/core_config_test.dart +++ b/packages/core/test/core_config_test.dart @@ -718,7 +718,7 @@ class _OnTapUrlApp extends StatelessWidget { }); @override - Widget build(BuildContext _) => MaterialApp( + Widget build(BuildContext context) => MaterialApp( home: Scaffold( body: HtmlWidget( 'Tap me', diff --git a/packages/core/test/style_background_test.dart b/packages/core/test/style_background_test.dart index f68a773bb..b3aab9b3f 100644 --- a/packages/core/test/style_background_test.dart +++ b/packages/core/test/style_background_test.dart @@ -459,7 +459,7 @@ class _Golden extends StatelessWidget { const _Golden(this.html); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( body: Padding( padding: const EdgeInsets.all(8.0), child: HtmlWidget( diff --git a/packages/core/test/style_display_flex_test.dart b/packages/core/test/style_display_flex_test.dart index 52f844ba8..94a63c716 100644 --- a/packages/core/test/style_display_flex_test.dart +++ b/packages/core/test/style_display_flex_test.dart @@ -535,7 +535,7 @@ class _Golden extends StatelessWidget { }); @override - Widget build(BuildContext _) { + Widget build(BuildContext context) { final inlineStyle = '$kCssDisplay: $kCssDisplayFlex; ' '$kCssFlexDirection: $flexDirection; ' '$kCssAlignItems: $alignItem; ' diff --git a/packages/core/test/style_sizing_test.dart b/packages/core/test/style_sizing_test.dart index ca83033f8..26c8916d8 100644 --- a/packages/core/test/style_sizing_test.dart +++ b/packages/core/test/style_sizing_test.dart @@ -821,7 +821,7 @@ class _Golden extends StatelessWidget { const _Golden(this.html); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( body: Padding( padding: const EdgeInsets.all(8.0), child: HtmlWidget(html), diff --git a/packages/core/test/tag_li_test.dart b/packages/core/test/tag_li_test.dart index fe3b97fdf..edfe65ff3 100644 --- a/packages/core/test/tag_li_test.dart +++ b/packages/core/test/tag_li_test.dart @@ -1024,7 +1024,7 @@ class _Golden extends StatelessWidget { const _Golden(this.contents); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( body: Padding( padding: const EdgeInsets.all(8.0), child: Column( diff --git a/packages/core/test/tag_table_test.dart b/packages/core/test/tag_table_test.dart index b38abdd62..f1c1c569b 100644 --- a/packages/core/test/tag_table_test.dart +++ b/packages/core/test/tag_table_test.dart @@ -1566,7 +1566,7 @@ class _Golden extends StatelessWidget { const _Golden(this.contents); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( body: Padding( padding: const EdgeInsets.all(8.0), child: HtmlWidget(contents), diff --git a/packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart b/packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart index 910802961..62c72e96a 100644 --- a/packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart +++ b/packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart @@ -151,7 +151,7 @@ class _PlayButton extends StatelessWidget { }); @override - Widget build(BuildContext _) => StreamBuilder( + Widget build(BuildContext context) => StreamBuilder( builder: (_, snapshot) { final isPlaying = snapshot.data ?? false; return IconButton( @@ -178,7 +178,7 @@ class _PositionText extends StatelessWidget { }); @override - Widget build(BuildContext _) => StreamBuilder( + Widget build(BuildContext context) => StreamBuilder( builder: (_, duration) => StreamBuilder( builder: (_, position) { final max = duration.data?.inSeconds ?? -1; @@ -268,7 +268,7 @@ class _MuteButton extends StatelessWidget { }); @override - Widget build(BuildContext _) => StreamBuilder( + Widget build(BuildContext context) => StreamBuilder( builder: (_, snapshot) { final isMuted = (snapshot.data ?? 1.0) == 0; return IconButton( diff --git a/packages/fwfh_svg/test/svg_factory_test.dart b/packages/fwfh_svg/test/svg_factory_test.dart index 856e20198..539a714e0 100644 --- a/packages/fwfh_svg/test/svg_factory_test.dart +++ b/packages/fwfh_svg/test/svg_factory_test.dart @@ -377,7 +377,7 @@ class _Golden extends StatelessWidget { }); @override - Widget build(BuildContext _) => Scaffold( + Widget build(BuildContext context) => Scaffold( body: Padding( padding: const EdgeInsets.all(8.0), child: HtmlWidget( diff --git a/packages/fwfh_url_launcher/test/_.dart b/packages/fwfh_url_launcher/test/_.dart index d467fec8b..8603caf60 100644 --- a/packages/fwfh_url_launcher/test/_.dart +++ b/packages/fwfh_url_launcher/test/_.dart @@ -6,8 +6,7 @@ import '../../core/test/_.dart' as helper; const tapText = helper.tapText; -Future explain(WidgetTester tester, String html) => - helper.explain( +Future explain(WidgetTester tester, String html) => helper.explain( tester, null, hw: HtmlWidget( diff --git a/packages/fwfh_webview/lib/src/web_view/fallback.dart b/packages/fwfh_webview/lib/src/web_view/fallback.dart index 4268be0fb..45044504f 100644 --- a/packages/fwfh_webview/lib/src/web_view/fallback.dart +++ b/packages/fwfh_webview/lib/src/web_view/fallback.dart @@ -4,5 +4,5 @@ import 'web_view.dart'; class WebViewState extends State { @override - Widget build(BuildContext _) => throw UnimplementedError(); + Widget build(BuildContext context) => throw UnimplementedError(); } diff --git a/packages/fwfh_webview/lib/src/web_view/js_interop.dart b/packages/fwfh_webview/lib/src/web_view/js_interop.dart index 512db6c87..3ac5587ed 100644 --- a/packages/fwfh_webview/lib/src/web_view/js_interop.dart +++ b/packages/fwfh_webview/lib/src/web_view/js_interop.dart @@ -34,7 +34,7 @@ class WebViewState extends State { } @override - Widget build(BuildContext _) => AspectRatio( + Widget build(BuildContext context) => AspectRatio( aspectRatio: widget.aspectRatio, child: _iframeWidget, ); diff --git a/sonar-project.properties b/sonar-project.properties index c8c5c1ab8..a842dc983 100644 --- a/sonar-project.properties +++ b/sonar-project.properties @@ -2,4 +2,5 @@ sonar.dart.lcov.reportPaths=packages/*/coverage/lcov.info sonar.projectKey=daohoangson_flutter_widget_from_html sonar.organization=daohoangson sonar.sources=packages -sonar.test.inclusions=**/test/* +sonar.test.inclusions=**/test/**/*, \ + packages/*/example/main.dart