Skip to content

Commit 5cb9bbe

Browse files
kanard38knard38
authored andcommitted
DAOS-16501 build: Support of mercury with ASan
Integrate reviewers comments: - Fix CI integration - Use of official mercury patch 74dda4a Miscellaneous fixes related to package build. Signed-off-by: Cedric Koch-Hofer <[email protected]>
1 parent 1f118db commit 5cb9bbe

File tree

7 files changed

+97
-21
lines changed

7 files changed

+97
-21
lines changed

debian/changelog

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,34 @@
1+
daos (2.7.101-17) unstable; urgency=medium
2+
[ Cedric Koch-Hofer]
3+
* Add support of the libasan to the mercury dependencies
4+
5+
-- Cedric Koch-Hofer <[email protected]> Mon, 27 Oct 2025 14:12:00 +0100
6+
7+
daos (2.7.101-16) unstable; urgency=medium
8+
[ Jeff Olivier]
9+
* Make daos-spdk conflict with spdk
10+
11+
-- Jeff Olivier <[email protected]> Mon, 19 May 2025 14:12:00 -0700
12+
13+
daos (2.7.101-15) unstable; urgency=medium
14+
[ Jeff Olivier]
15+
* Fix leap package name
16+
17+
-- Jeff Olivier <[email protected]> Fri, 12 Sep 2025 14:12:00 -0700
18+
19+
daos (2.7.101-14) unstable; urgency=medium
20+
[ Jeff Olivier]
21+
* Fix pmdk package for leap
22+
* Fix daos-spdk package
23+
24+
-- Jeff Olivier <[email protected]> Thu, 11 Sep 2025 14:12:00 -0700
25+
26+
daos (2.7.101-13) unstable; urgency=medium
27+
[ Jeff Olivier]
28+
* Switch to fpm build for RPMs
29+
30+
-- Jeff Olivier <[email protected]> Mon, 11 Aug 2025 14:12:00 -0700
31+
132
daos (2.7.101-12) unstable; urgency=medium
233
[ Tomasz Gromadzki ]
334
* pmemobj errors and warnings reported via DAOS logging system
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
diff --git a/CMakeLists.txt b/CMakeLists.txt
2+
index c5161c1..e4e7971 100644
3+
--- a/CMakeLists.txt
4+
+++ b/CMakeLists.txt
5+
@@ -170,6 +170,12 @@ else()
6+
set(MERCURY_LIBTYPE STATIC)
7+
endif()
8+
9+
+#------------------------------------------------------------------------------
10+
+# Set debug lib name as release.
11+
+#------------------------------------------------------------------------------
12+
+option(MERCURY_LIB_DEBUG_NAME_IS_RELEASE "Set debug library name as release." OFF)
13+
+mark_as_advanced(MERCURY_LIB_DEBUG_NAME_IS_RELEASE)
14+
+
15+
#------------------------------------------------------------------------------
16+
# Enable debug output.
17+
#------------------------------------------------------------------------------
18+
@@ -237,16 +243,29 @@ function(mercury_set_lib_options libtarget libname libtype var_prefix)
19+
endif()
20+
endif()
21+
22+
- set_target_properties(${libtarget}
23+
- PROPERTIES
24+
- OUTPUT_NAME_DEBUG ${LIB_DEBUG_NAME}
25+
- OUTPUT_NAME_RELEASE ${LIB_RELEASE_NAME}
26+
- OUTPUT_NAME_MINSIZEREL ${LIB_RELEASE_NAME}
27+
- OUTPUT_NAME_RELWITHDEBINFO ${LIB_RELEASE_NAME}
28+
- OUTPUT_NAME_ASAN ${LIB_DEBUG_NAME}
29+
- OUTPUT_NAME_TSAN ${LIB_DEBUG_NAME}
30+
- OUTPUT_NAME_UBSAN ${LIB_DEBUG_NAME}
31+
- )
32+
+ if(NOT MERCURY_LIB_DEBUG_NAME_IS_RELEASE)
33+
+ set_target_properties(${libtarget}
34+
+ PROPERTIES
35+
+ OUTPUT_NAME_DEBUG ${LIB_DEBUG_NAME}
36+
+ OUTPUT_NAME_RELEASE ${LIB_RELEASE_NAME}
37+
+ OUTPUT_NAME_MINSIZEREL ${LIB_RELEASE_NAME}
38+
+ OUTPUT_NAME_RELWITHDEBINFO ${LIB_RELEASE_NAME}
39+
+ OUTPUT_NAME_ASAN ${LIB_DEBUG_NAME}
40+
+ OUTPUT_NAME_TSAN ${LIB_DEBUG_NAME}
41+
+ OUTPUT_NAME_UBSAN ${LIB_DEBUG_NAME}
42+
+ )
43+
+ else()
44+
+ set_target_properties(${libtarget}
45+
+ PROPERTIES
46+
+ OUTPUT_NAME_DEBUG ${LIB_RELEASE_NAME}
47+
+ OUTPUT_NAME_RELEASE ${LIB_RELEASE_NAME}
48+
+ OUTPUT_NAME_MINSIZEREL ${LIB_RELEASE_NAME}
49+
+ OUTPUT_NAME_RELWITHDEBINFO ${LIB_RELEASE_NAME}
50+
+ OUTPUT_NAME_ASAN ${LIB_RELEASE_NAME}
51+
+ OUTPUT_NAME_TSAN ${LIB_RELEASE_NAME}
52+
+ OUTPUT_NAME_UBSAN ${LIB_RELEASE_NAME}
53+
+ )
54+
+ endif()
55+
if(${libtype} MATCHES "SHARED")
56+
set_target_properties(${libtarget}
57+
PROPERTIES

deps/patches/mercury/0004_asan_workaround.patch

Lines changed: 0 additions & 17 deletions
This file was deleted.

site_scons/components/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,8 @@ def define_mercury(reqs):
219219
except KeyError:
220220
pass
221221
mercury_build.append(f'-DCMAKE_BUILD_TYPE:STRING={build_type}')
222+
if build_type != "RelWithDebInfo":
223+
mercury_build.append('-DMERCURY_LIB_DEBUG_NAME_IS_RELEASE:BOOL=ON')
222224

223225
if reqs.target_type == 'debug':
224226
mercury_build.append('-DMERCURY_ENABLE_DEBUG:BOOL=ON')

utils/build.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ ucx=https://github.com/openucx/ucx.git
2727

2828
[patch_versions]
2929
spdk=0001_b0aba3fcd5aceceea530a702922153bc75664978.diff,0002_445a4c808badbad3942696ecf16fa60e8129a747.diff
30-
mercury=0001_na_ucx.patch,0002_na_ucx_ep_flush.patch,0003_combined_plugin_path.patch,0004_asan_workaround.patch
30+
mercury=0001_na_ucx.patch,0002_na_ucx_ep_flush.patch,0003_combined_plugin_path.patch,0004-CMake-add-MERCURY_LIB_DEBUG_NAME_IS_RELEASE-option.patch
3131
argobots=0001_411e5b344642ebc82190fd8b125db512e5b449d1.diff,0002_bb0c908abfac4bfe37852eee621930634183c6aa.diff

utils/rpms/daos.spec

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
Name: daos
2727
Version: 2.7.101
28-
Release: 16%{?relval}%{?dist}
28+
Release: 17%{?relval}%{?dist}
2929
Summary: DAOS Storage Engine
3030

3131
License: BSD-2-Clause-Patent
@@ -659,10 +659,13 @@ fi
659659
%endif
660660

661661
%changelog
662+
* Mon Oct 27 2025 Cedric Koch-Hofer <[email protected]> 2.7.101-17
663+
- Add support of the libasan to the mercury dependencies
664+
662665
* Thu Oct 16 2025 Jeff Olivier <[email protected]> 2.7.101-16
663666
- Make daos-spdk conflict with spdk
664667

665-
* Thu Sep 12 2025 Jeff Olivier <[email protected]> 2.7.101-15
668+
* Fri Sep 12 2025 Jeff Olivier <[email protected]> 2.7.101-15
666669
- Fix leap package name
667670

668671
* Thu Sep 11 2025 Jeff Olivier <[email protected]> 2.7.101-14

utils/rpms/package_info.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export libfabric_version="1.22.0"
3838
export libfabric_release="4${distro_name}"
3939
export libfabric_full="${libfabric_version}-${libfabric_release}"
4040
export mercury_version="2.4.0"
41-
export mercury_release="7${distro_name}"
41+
export mercury_release="8${distro_name}"
4242
export mercury_full="${mercury_version}-${mercury_release}"
4343
export argobots_version="1.2"
4444
export argobots_release="3${distro_name}"

0 commit comments

Comments
 (0)