Skip to content

Commit 74f44e0

Browse files
committed
Updates
Skip-func-test: true Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
1 parent 71df824 commit 74f44e0

File tree

6 files changed

+32
-21
lines changed

6 files changed

+32
-21
lines changed

Jenkinsfile

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -285,21 +285,6 @@ Map unit_test_post_args(String name) {
285285
return args
286286
}
287287

288-
Map nlt_post_args() {
289-
Map args = [
290-
artifacts: ['nlt_logs/'],
291-
testResults: 'nlt-junit.xml',
292-
always_script: 'ci/unit/test_nlt_post.sh',
293-
valgrind_stash: 'el8-gcc-nlt-memcheck'
294-
]
295-
if (code_coverage_enabled()) {
296-
// args['artifacts'].add('covc_nlt_logs/')
297-
args['ignore_failure'] = true
298-
args['code_coverage'] = true
299-
}
300-
return args
301-
}
302-
303288
String getScriptOutput(String script, String args='') {
304289
return sh(script: "${script} ${args}", returnStdout: true).trim()
305290
}
@@ -1234,7 +1219,7 @@ pipeline {
12341219
}
12351220
post {
12361221
always {
1237-
unitTestPost artifacts: ['nlt_logs/'],
1222+
unitTestPost artifacts: ['nlt_bullseye_logs/'],
12381223
testResults: 'nlt-junit.xml',
12391224
always_script: 'ci/unit/test_nlt_post.sh',
12401225
compiler: 'covc',

ci/unit/test_nlt.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# This is the script used for running utils/node_local_test.py (NLT)
44
set -uex
55

6-
rm -rf nlt_logs
6+
rm -rf nlt_logs nlt_bullseye_logs
77

88
# Remove any logs from a previous run
99
rm -rf dnt.*.memcheck.xml vm_test/

ci/unit/test_nlt_node.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ if [ -d "${BULLSEYE_DIR}" ]; then
5454
cp "${BULLSEYE_DIR}/daos/test.cov" "${COVFILE}"
5555
ls -al "${COVFILE}"
5656
nlt_args+=(--memcheck no)
57+
nlt_args+=(--log-base-dir nlt_bullseye_logs)
5758
fi
5859

5960
if [ -e "${COVFILE:-}" ]; then

ci/unit/test_nlt_post.sh

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,29 @@ set -uex
77

88
NODE="${NODELIST%%,*}"
99

10-
rm -rf nlt_logs
11-
mkdir nlt_logs
10+
case $STAGE_NAME in
11+
"NLT on "*)
12+
test_log_dir="nlt_logs"
13+
;;
14+
"NLT with Bullseye on "*)
15+
test_log_dir="nlt_bullseye_logs"
16+
;;
17+
*)
18+
echo "Unexpected STAGE_NAME '$STAGE_NAME' in test_nlt_post.sh"
19+
exit 1
20+
;;
21+
esac
22+
23+
rm -rf "$test_log_dir"
24+
mkdir "$test_log_dir"
1225

1326
# Copy any log files. Use rsync filters here to allow us to specify
1427
# all files we want to copy, as it's much more flexible than using
1528
# standard wildcards.
1629
rsync -v -dprt -e "ssh $SSH_KEY_ARGS" jenkins@"$NODE":/tmp/ \
1730
--filter="include dnt*.log" --filter="include dnt*.log.bz2" \
1831
--filter="include dnt_fi_*_logs" --filter="include test.cov" \
19-
--filter="exclude *" nlt_logs/
32+
--filter="exclude *" "${test_log_dir}/"
2033

2134
rsync -v -dpt -z -e "ssh $SSH_KEY_ARGS" jenkins@"$NODE":build/ \
2235
--filter="include nlt*.json" --filter="include dnt*.xml" \

ci/unit/test_post_always.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,18 @@ case $STAGE_NAME in
3535
"NLT on "*)
3636
test_log_dir="nlt_logs"
3737
;;
38+
"NLT with Bullseye on "*)
39+
test_log_dir="nlt_bullseye_logs"
40+
;;
3841
"Unit Test with memcheck on "*)
3942
test_log_dir="unit_test_memcheck_logs"
4043
;;
4144
"Unit Test bdev with memcheck on "*)
4245
test_log_dir="unit_test_memcheck_bdev_logs"
4346
;;
47+
"Unit Test with Bullseye on "*)
48+
test_log_dir="unit_test_bullseye_logs"
49+
;;
4450
*)
4551
test_log_dir="unkown_test_logs"
4652
;;

utils/node_local_test.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def __init__(self, json_file, args):
117117
prefix='dnt_dfuse_')
118118
self.tmp_dir = None
119119
if args.class_name:
120-
self.tmp_dir = join('nlt_logs', args.class_name)
120+
self.tmp_dir = join(args.log_base_dir, args.class_name)
121121
if os.path.exists(self.tmp_dir):
122122
for old_file in os.listdir(self.tmp_dir):
123123
os.unlink(join(self.tmp_dir, old_file))
@@ -443,6 +443,11 @@ def get_base_env(clean=False):
443443
if http_proxy:
444444
env['HTTPS_PROXY'] = http_proxy
445445

446+
# If set, retain the COVFILE for bullseye code coverage
447+
covfile = os.environ.get('COVFILE')
448+
if covfile:
449+
env['COVFILE'] = covfile
450+
446451
# Enable this to debug memory errors, it has a performance impact but will scan the heap
447452
# for corruption. See DAOS-12735 for why this can cause problems in practice.
448453
# env['MALLOC_CHECK_'] = '3'
@@ -6842,6 +6847,7 @@ def main():
68426847
parser.add_argument('--exclude-test', action='append',
68436848
help='space separated list of tests to exclude')
68446849
parser.add_argument('--valgrind_verbose', action='store_true', help='Use --verbose w/ valgrind')
6850+
parser.add_argument('--log-base-dir', default='nlt_logs', help='Base directory for log files')
68456851
parser.add_argument('mode', nargs='*')
68466852
args = parser.parse_args()
68476853

0 commit comments

Comments
 (0)