DAOS-17783 test: Suppress NLT false positives in Go (#16615)

kjacque · web-flow · commit 81265201f81f · 2025-07-24T14:24:59.000-07:00
An additional case of tsan::TraceRestartMemoryAccess with a slightly
different call stack. This is a false positive coming from the Go
runtime.

Also moved another tsan suppression to be near similar ones, and named
them more descriptively.

Signed-off-by: Kris Jacque &lt;kris.jacque@hpe.com&gt;
diff --git a/src/cart/utils/memcheck-cart.supp b/src/cart/utils/memcheck-cart.supp
@@ -647,15 +647,24 @@
    fun:racecall
 }
 {
-   go 1.22.3 race
+   tsan::MemoryAccessRange
    Memcheck:Value8
    fun:_ZN6__tsan18MemoryAccessRangeTILb0EEEvPNS_11ThreadStateEmmm
+   ...
+   fun:racecall
+}
+{
+   tsan::MemoryAccessRange
+   Memcheck:Value8
+   fun:_ZN6__tsan18MemoryAccessRangeTILb1EEEvPNS_11ThreadStateEmmm
+   ...
    fun:racecall
 }
 {
-   go 1.22.3 race
+   tsan::TraceRestartMemoryAccess
    Memcheck:Value8
    fun:_ZN6__tsan24TraceRestartMemoryAccessEPNS_11ThreadStateEmmmm
+   ...
    fun:racecall
 }
 {
@@ -719,12 +728,6 @@
    ...
    fun:runtime.rt0_go.abi0
 }
-{
-   tsan::MemoryAccessRange
-   Memcheck:Value8
-   fun:_ZN6__tsan18MemoryAccessRangeTILb1EEEvPNS_11ThreadStateEmmm
-   fun:racecall
-}
 {
    bytealg.cmpbody 32-bit
    Memcheck:Addr32

Original file line number	Diff line number	Diff line change
`@@ -647,15 +647,24 @@`
`647`	`647`	`fun:racecall`
`648`	`648`	`}`
`649`	`649`	`{`
`650`		`- go 1.22.3 race`
	`650`	`+ tsan::MemoryAccessRange`
`651`	`651`	`Memcheck:Value8`
`652`	`652`	`fun:_ZN6__tsan18MemoryAccessRangeTILb0EEEvPNS_11ThreadStateEmmm`
	`653`	`+ ...`
	`654`	`+ fun:racecall`
	`655`	`+}`
	`656`	`+{`
	`657`	`+ tsan::MemoryAccessRange`
	`658`	`+ Memcheck:Value8`
	`659`	`+ fun:_ZN6__tsan18MemoryAccessRangeTILb1EEEvPNS_11ThreadStateEmmm`
	`660`	`+ ...`
`653`	`661`	`fun:racecall`
`654`	`662`	`}`
`655`	`663`	`{`
`656`		`- go 1.22.3 race`
	`664`	`+ tsan::TraceRestartMemoryAccess`
`657`	`665`	`Memcheck:Value8`
`658`	`666`	`fun:_ZN6__tsan24TraceRestartMemoryAccessEPNS_11ThreadStateEmmmm`
	`667`	`+ ...`
`659`	`668`	`fun:racecall`
`660`	`669`	`}`
`661`	`670`	`{`
`@@ -719,12 +728,6 @@`
`719`	`728`	`...`
`720`	`729`	`fun:runtime.rt0_go.abi0`
`721`	`730`	`}`
`722`		`-{`
`723`		`- tsan::MemoryAccessRange`
`724`		`- Memcheck:Value8`
`725`		`- fun:_ZN6__tsan18MemoryAccessRangeTILb1EEEvPNS_11ThreadStateEmmm`
`726`		`- fun:racecall`
`727`		`-}`
`728`	`731`	`{`
`729`	`732`	`bytealg.cmpbody 32-bit`
`730`	`733`	`Memcheck:Addr32`