DAOS-18292 ddb: Debug level of the DDB GO code can not be defined

Properly configure C DAOS debug facilities from Golang DDB code.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <[email protected]>

Author: kanard38

src/control/cmd/ddb/main.go

@@ -179,10 +179,36 @@ Example Paths:
 		return nil
 	}
 
+	if os.Getenv("DD_MASK") == "" {
+		os.Setenv("DD_MASK", "mgmt,epc,csum,md,df,io,trace")
+	}
 	if opts.Debug {
-		log.WithLogLevel(logging.LogLevelDebug)
-		log.Debug("debug output enabled")
+		log.WithLogLevel(logging.LogLevelTrace)
+		if os.Getenv("D_LOG_MASK") == "" {
+			os.Setenv("D_LOG_MASK", "INFO,DDB=DEBUG")
+		}
+		// Show debug output and above on stderr to not pollute stdout
+		// NOTE: DD_STDERR can only be used with INFO and above.
+		if os.Getenv("DD_STDERR") == "" {
+			os.Setenv("DD_STDERR", "EMIT")
+		}
+		if os.Getenv("D_LOG_FILE") == "" {
+			os.Setenv("D_LOG_FILE", "/dev/stderr")
+		}
+	} else {
+		log.WithLogLevel(logging.LogLevelError)
+		if os.Getenv("D_LOG_MASK") == "" {
+			os.Setenv("D_LOG_MASK", "ERR,DDB=WARN")
+		}
+		// Only show warnings and above on stderr to not pollute stdout
+		if os.Getenv("DD_STDERR") == "" {
+			os.Setenv("DD_STDERR", "WARN")
+		}
+		if os.Getenv("D_LOG_FILE") == "" {
+			os.Setenv("D_LOG_FILE", "/dev/null")
+		}
 	}
+	log.Debug("debug output enabled")
 
 	ctx, cleanup, err := InitDdb(log)
 	if err != nil {

src/include/daos/debug.h

@@ -55,7 +55,8 @@
 	ACTION(il, il, arg)                                                                        \
 	ACTION(csum, csum, arg)                                                                    \
 	ACTION(pipeline, pipeline, arg)                                                            \
-	ACTION(stack, stack, arg)
+	ACTION(stack, stack, arg)                                                                  \
+	ACTION(ddb, ddb, arg)
 
 #define DAOS_FOREACH_DB(ACTION, arg)				\
 	/** metadata operation */				\

src/utils/ddb/ddb.c

@@ -5,9 +5,12 @@
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
+#define D_LOGFAC DD_FAC(ddb)
+
 #include <stdlib.h>
 #include <string.h>
 #include <limits.h>
+
 #include <daos_errno.h>
 #include <daos_srv/vos.h>
 

src/utils/ddb/ddb_commands.c

@@ -5,24 +5,24 @@
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
+#define D_LOGFAC DD_FAC(ddb)
 
-#include <daos/common.h>
-#include <daos_srv/vos.h>
 #include <sys/types.h>
 #include <time.h>
 
-#include "daos_errno.h"
-#include "daos_srv/vos_types.h"
-#include "daos_types.h"
+#include <daos.h>
+#include <daos_errno.h>
+#include <daos_types.h>
+#include <daos/common.h>
+#include <daos_srv/vos.h>
+#include <daos_srv/vos_types.h>
+
 #include "ddb_common.h"
 #include "ddb_parse.h"
 #include "ddb.h"
 #include "ddb_vos.h"
 #include "ddb_printer.h"
-#include "daos.h"
 #include "ddb_tree_path.h"
-#include "gurt/common.h"
-#include "gurt/debug.h"
 
 #define ilog_path_required_error_message "Path to object, dkey, or akey required\n"
 #define error_msg_write_mode_only "Can only modify the VOS tree in 'write mode'\n"

src/utils/ddb/ddb_main.c

@@ -5,15 +5,18 @@
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
+#define D_LOGFAC DD_FAC(ddb)
+
+#include <stdarg.h>
+#include <sys/stat.h>
 
 #include <daos/common.h>
 #include <daos/object.h>
+
+#include "ddb.h"
 #include "ddb_common.h"
 #include "ddb_parse.h"
 #include "ddb_vos.h"
-#include "ddb.h"
-#include <stdarg.h>
-#include <sys/stat.h>
 
 int
 ddb_init()

src/utils/ddb/ddb_mgmt.c

@@ -4,6 +4,7 @@
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
+#define D_LOGFAC DD_FAC(ddb)
 
 #include <ftw.h>
 #include <unistd.h>
@@ -13,7 +14,6 @@
 #include <sys/sysinfo.h>
 #include <linux/magic.h>
 
-#include <gurt/debug.h>
 #include <daos_srv/control.h>
 #include <daos_srv/smd.h>
 #include <daos_srv/mgmt_tgt_common.h>

src/utils/ddb/ddb_parse.c

@@ -4,11 +4,13 @@
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
+#define D_LOGFAC DD_FAC(ddb)
 
 #include <wordexp.h>
 #include <getopt.h>
-#include <gurt/common.h>
-#include "daos_errno.h"
+
+#include <daos_errno.h>
+
 #include "ddb_common.h"
 #include "ddb_parse.h"
 

src/utils/ddb/ddb_printer.c

@@ -4,6 +4,7 @@
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
+#define D_LOGFAC DD_FAC(ddb)
 
 #include "ddb_printer.h"
 

src/utils/ddb/ddb_spdk.c

@@ -4,17 +4,19 @@
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
+#define D_LOGFAC DD_FAC(ddb)
 
-#include <bio_internal.h>
-#include <bio_wal.h>
+#include <uuid/uuid.h>
 #include <spdk/stdinc.h>
 #include <spdk/bdev.h>
 #include <spdk/env.h>
 #include <spdk/event.h>
 #include <spdk/blob_bdev.h>
 #include <spdk/blob.h>
 #include <spdk/string.h>
-#include <uuid/uuid.h>
+
+#include <bio_internal.h>
+#include <bio_wal.h>
 
 #include "ddb_common.h"
 #include "ddb_spdk.h"

src/utils/ddb/ddb_tree_path.c

@@ -1,8 +1,10 @@
 /**
  * (C) Copyright 2023-2024 Intel Corporation.
+ * (C) Copyright 2025 Hewlett Packard Enterprise Development LP
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
+#define D_LOGFAC DD_FAC(ddb)
 
 #include "ddb_tree_path.h"
 #include "ddb_printer.h"