DAOS-18494 control: Don't use default sys in daos pool list (#17384)

Removed a case where we were still substituting the default
system name in the daos pool list command.

Signed-off-by: Kris Jacque <kris.jacque@hpe.com>

Author: kjacque

src/control/lib/daos/api/pool.go

@@ -13,7 +13,6 @@ import (
 	"github.com/google/uuid"
 	"github.com/pkg/errors"
 
-	"github.com/daos-stack/daos/src/control/build"
 	"github.com/daos-stack/daos/src/control/lib/daos"
 	"github.com/daos-stack/daos/src/control/lib/ranklist"
 	"github.com/daos-stack/daos/src/control/logging"
@@ -670,11 +669,11 @@ func GetPoolList(ctx context.Context, req GetPoolListReq) ([]*daos.PoolInfo, err
 	log := logging.FromContext(ctx)
 	log.Debugf("GetPoolList(%+v)", req)
 
-	if req.SysName == "" {
-		req.SysName = build.DefaultSystemName
+	var cSysName *C.char
+	if req.SysName != "" {
+		cSysName = C.CString(req.SysName)
+		defer freeString(cSysName)
 	}
-	cSysName := C.CString(req.SysName)
-	defer freeString(cSysName)
 
 	var cPools []C.daos_mgmt_pool_info_t
 	for {

src/control/lib/daos/api/pool_test.go

@@ -955,11 +955,11 @@ func TestAPI_GetPoolList(t *testing.T) {
 			ctx:      test.Context(t),
 			expPools: defaultPoolInfoResp,
 		},
-		"default system name supplied": {
+		"empty system name supplied": {
 			ctx: test.Context(t),
 			req: GetPoolListReq{},
 			checkParams: func(t *testing.T) {
-				test.CmpAny(t, "sysName", build.DefaultSystemName, daos_mgmt_list_pools_SetSys)
+				test.CmpAny(t, "sysName", "", daos_mgmt_list_pools_SetSys)
 			},
 			expPools: defaultPoolInfoResp,
 		},