DAOS-17973 control: Allow none for pool property self_heal (#16848)

It is impossible to turn off all flags of pool property self_heal,
because dmg pool set-prop disallows empty value syntax. This patch adds
"none" as a valid value for pool property self_heal, to indicate that
all flags are turned off.

Signed-off-by: Li Wei <[email protected]>

Author: liw

src/control/cmd/dmg/pool_test.go

@@ -771,6 +771,20 @@ func TestPoolCommands(t *testing.T) {
 			}, " "),
 			nil,
 		},
+		{
+			"Set pool properties with self_heal value 'none'",
+			`pool set-prop 031bcaf8-f0f5-42ef-b3c5-ee048676dceb self_heal:none,space_rb:42`,
+			strings.Join([]string{
+				printRequest(t, &control.PoolSetPropReq{
+					ID: "031bcaf8-f0f5-42ef-b3c5-ee048676dceb",
+					Properties: []*daos.PoolProperty{
+						propWithVal("self_heal", "none"),
+						propWithVal("space_rb", "42"),
+					},
+				}),
+			}, " "),
+			nil,
+		},
 		{
 			"Set pool properties with pool flag",
 			"pool set-prop 031bcaf8-f0f5-42ef-b3c5-ee048676dceb label:foo,space_rb:42",

src/control/lib/daos/pool_property.go

@@ -53,6 +53,8 @@ func PoolProperties() PoolPropertyMap {
 						return "not set"
 					}
 					switch n {
+					case 0:
+						return "none"
 					case PoolSelfHealingAutoExclude:
 						return "exclude"
 					case PoolSelfHealingAutoRebuild:
@@ -69,6 +71,7 @@ func PoolProperties() PoolPropertyMap {
 				},
 			},
 			values: map[string]uint64{
+				"none":                  0,
 				"exclude":               PoolSelfHealingAutoExclude,
 				"rebuild":               PoolSelfHealingAutoRebuild,
 				"delay_rebuild":         PoolSelfHealingDelayRebuild,

src/tests/suite/daos_pool.c

@@ -1,5 +1,6 @@
 /**
  * (C) Copyright 2016-2023 Intel Corporation.
+ * (C) Copyright 2025 Hewlett Packard Enterprise Development LP
  *
  * SPDX-License-Identifier: BSD-2-Clause-Patent
  */
@@ -735,7 +736,7 @@ pool_op_retry(void **state)
 	/* pool set prop success committed, "lost" reply - duplicate RPC retry */
 	test_set_engine_fail_loc(arg, leader_rank, DAOS_MD_OP_PASS_NOREPLY | DAOS_FAIL_ONCE);
 	print_message("set pool prop (retry / dup rpc detection)... ");
-	rc = daos_pool_set_prop(arg->pool.pool_uuid, "self_heal", "rebuild");
+	rc = daos_pool_set_prop(arg->pool.pool_uuid, "self_heal", "none");
 	assert_rc_equal(rc, 0);
 	print_message("success\n");