Skip to content

DAOS-18382 control: Make ddb vos_path optional #17359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kjacque wants to merge 7 commits into
base: master
Choose a base branch
from
Open

DAOS-18382 control: Make ddb vos_path optional #17359

kjacque wants to merge 7 commits into from
+20 −22

Conversation

@kjacque
Copy link
Contributor

@kjacque kjacque commented Jan 9, 2026 •
edited
Loading

For ddb, vos_path was previously a required positional parameter even for commands that didn't use it. With this change, --vos_path is a named parameter to be used only with commands that require it.

Features: recovery ddb_cmd

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@kjacque
DAOS-18382 control: Make ddb vos_path optional
992f037 
For ddb, vos_path was previously a required positional parameter
even for commands that didn't use it. With this change, --vos_path
is a named parameter to be used only with commands that require it.

Features: recovery ddb_cmd

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque self-assigned this Jan 9, 2026
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Ticket title is 'Remove unnecessary placeholder in ddb command input'
Status is 'In Progress'
Labels: 'scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-18382

janekmi
janekmi previously approved these changes Jan 9, 2026
View reviewed changes
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 13, 2026

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17359/4/execution/node/1069/log

@kjacque
Merge branch 'master' into kjacque/ddb-vospath
77eac0b 
Features: recovery ddb_cmd
@kjacque
Fix help for vos_path param
d6f2e62 
Also force a position for the --vos_path option in tests.

Features: recovery ddb_cmd

Signed-off-by: Kris Jacque <[email protected]>
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 14, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17359/5/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 15, 2026

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17359/5/execution/node/1050/log

@kjacque
Merge branch 'master' into kjacque/ddb-vospath
e018a77
@kjacque
Fix typo
48a416a 
Features: recovery ddb_cmd

Signed-off-by: Kris Jacque <[email protected]>
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 16, 2026

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17359/8/testReport/

@kjacque kjacque marked this pull request as ready for review January 17, 2026 01:54
@kjacque kjacque requested review from a team as code owners January 17, 2026 01:54
@kjacque kjacque requested a review from janekmi January 17, 2026 01:54
@kjacque
Copy link
Contributor Author

kjacque commented Jan 17, 2026

Test failures don't involve ddb and appear to be unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janekmi janekmi Awaiting requested review from janekmi

At least 2 approving reviews are required to merge this pull request.

Assignees

@kjacque kjacque

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kjacque @daosbuild3 @janekmi