[668]: adds fill rewrite for EwSubOp

Signed-off-by: Maximilian Ehlers <daphnevm@sodawa.com>

Author: Maximilian Ehlers

src/ir/daphneir/Canonicalize.cpp

@@ -323,6 +323,22 @@ mlir::LogicalResult mlir::daphne::EwAddOp::canonicalize(mlir::daphne::EwAddOp op
 mlir::LogicalResult mlir::daphne::EwSubOp::canonicalize(mlir::daphne::EwSubOp op, PatternRewriter &rewriter) {
     mlir::Value lhs = op.getLhs();
     mlir::Value rhs = op.getRhs();
+    // This will check for the fill operation on the left hand side to push down the arithmetic inside
+    // of it
+    mlir::daphne::FillOp lhsFill = lhs.getDefiningOp<mlir::daphne::FillOp>();
+    if (lhsFill) {
+        auto fillValue = lhsFill.getArg();
+        auto height = lhsFill.getNumRows();
+        auto width = lhsFill.getNumCols();
+        const bool rhsIsSca = CompilerUtils::isScaType(rhs.getType());
+        if (rhsIsSca) {
+            mlir::daphne::EwAddOp newSub = rewriter.create<mlir::daphne::EwSubOp>(op.getLoc(), fillValue, rhs);
+            mlir::daphne::FillOp newFill =
+                rewriter.create<mlir::daphne::FillOp>(op.getLoc(), op.getResult().getType(), newAdd, width, height);
+            rewriter.replaceOp(op, {newFill});
+            return mlir::success();
+        }
+    }
     const bool lhsIsSca = CompilerUtils::isScaType(lhs.getType());
     const bool rhsIsSca = CompilerUtils::isScaType(rhs.getType());
     if (lhsIsSca && !rhsIsSca) {

test/ir/daphneir/pushdown_arithmetics/ewSub.mlir

@@ -0,0 +1,22 @@
+// RUN: daphne-opt --canonicalize --inline %s | FileCheck %s
+
+module {
+  func.func @main() {
+    %0 = "daphne.constant"() {value = 1 : si64} : () -> si64
+    %1 = "daphne.constant"() {value = 4 : si64} : () -> si64
+    %2 = "daphne.constant"() {value = 3 : si64} : () -> si64
+    %3 = "daphne.constant"() {value = 3 : si64} : () -> si64
+    %4 = "daphne.cast"(%2) : (si64) -> index
+    %5 = "daphne.cast"(%3) : (si64) -> index
+    // CHECK: daphne.fill
+    // CHECK-NOT: daphne.fill
+    %6 = "daphne.fill"(%1, %4, %5) : (si64, index, index) -> !daphne.Matrix<?x?xsi64>
+    // CHECK-NOT: daphne.ewSub
+    %7 = "daphne.ewSub"(%0, %6) : (si64, !daphne.Matrix<?x?xsi64>) -> !daphne.Matrix<?x?xsi64>
+    %8 = "daphne.constant"() {value = true} : () -> i1
+    %9 = "daphne.constant"() {value = false} : () -> i1
+    "daphne.print"(%7, %8, %9) : (!daphne.Matrix<?x?xsi64>, i1, i1) -> ()
+    "daphne.return"() : () -> ()
+  }
+}
+