[668]: renames trait PushDownWithIntervalUpdate to PushDownIncrementUpdate

Signed-off-by: Maximilian Ehlers <daphnevm@sodawa.com>

Author: Maximilian Ehlers

src/ir/daphneir/Canonicalize.cpp

@@ -376,7 +376,7 @@ template <class Operation> bool tryPushDownBinary(Operation op, mlir::PatternRew
     const bool rhsIsSca = CompilerUtils::isScaType(rhs.getType());
 
     const bool supportsPushDownLinear = op->template hasTrait<mlir::OpTrait::PushDownLinear>();
-    const bool supportsPushDownWithIntervalUpdate = op->template hasTrait<mlir::OpTrait::PushDownWithIntervalUpdate>();
+    const bool supportsPushDownIncrementUpdate = op->template hasTrait<mlir::OpTrait::PushDownIncrementUpdate>();
 
     // This will check for the fill operation to push down the arithmetic inside
     // of it
@@ -426,7 +426,7 @@ template <class Operation> bool tryPushDownBinary(Operation op, mlir::PatternRew
         auto newFrom = rewriter.create<Operation>(op.getLoc(), from, rhs);
         auto newTo = rewriter.create<Operation>(op.getLoc(), to, rhs);
 
-        if (supportsPushDownWithIntervalUpdate) {
+        if (supportsPushDownIncrementUpdate) {
             auto incInt = CompilerUtils::isConstant<int>(inc);
             auto valueInt = CompilerUtils::isConstant<int>(rhs);
             auto valueDouble = CompilerUtils::isConstant<double>(rhs);

src/ir/daphneir/DaphneOps.td

@@ -352,10 +352,10 @@ def Daphne_EwAddOp    : Daphne_EwBinaryOp<"ewAdd", AnyScalar, [ValueTypeFromArgs
 def Daphne_EwSubOp    : Daphne_EwBinaryOp<"ewSub", NumScalar, [ValueTypeFromArgs, CastArgsToResType, EwSparseIfBoth, CUDASupport, PushDownLinear]> {
     let hasCanonicalizeMethod = 1;
 }
-def Daphne_EwMulOp    : Daphne_EwBinaryOp<"ewMul", NumScalar, [ValueTypeFromArgs, CastArgsToResType, Commutative, EwSparseIfEither, CUDASupport, PushDownLinear, PushDownWithIntervalUpdate]> {
+def Daphne_EwMulOp    : Daphne_EwBinaryOp<"ewMul", NumScalar, [ValueTypeFromArgs, CastArgsToResType, Commutative, EwSparseIfEither, CUDASupport, PushDownLinear, PushDownIncrementUpdate]> {
     let hasCanonicalizeMethod = 1;
 }
-def Daphne_EwDivOp    : Daphne_EwBinaryOp<"ewDiv", NumScalar, [ValueTypeFromArgs, CastArgsToResType, CUDASupport, PushDownLinear, PushDownWithIntervalUpdate]> {
+def Daphne_EwDivOp    : Daphne_EwBinaryOp<"ewDiv", NumScalar, [ValueTypeFromArgs, CastArgsToResType, CUDASupport, PushDownLinear, PushDownIncrementUpdate]> {
     let hasCanonicalizeMethod = 1;
 }
 def Daphne_EwPowOp    : Daphne_EwBinaryOp<"ewPow", NumScalar, [ValueTypeFromArgs, CastArgsToResType, CUDASupport]> {

src/ir/daphneir/DaphnePushDownTraits.h

@@ -4,15 +4,20 @@
 namespace mlir::OpTrait {
 
 // ============================================================================
-// Traits determining pushdown rewrite possibilities
+// Traits determining advanced push-down rewrite possibilities
 // ============================================================================
 
-// Dynamic First Argument
-
-template <class ConcreteOp> class PushDown : public TraitBase<ConcreteOp, PushDown> {};
+/**
+ * @brief This trait is for operations that are linear and might allow for push-downs into functions that
+ * act on e.g. ranges
+ */
 template <class ConcreteOp> class PushDownLinear : public TraitBase<ConcreteOp, PushDownLinear> {};
-template <class ConcreteOp>
-class PushDownWithIntervalUpdate : public TraitBase<ConcreteOp, PushDownWithIntervalUpdate> {};
+
+/**
+ * @brief This trait is for operations that are using an increment value which
+ * needs to be accounted for during push-down optimizations
+ */
+template <class ConcreteOp> class PushDownIncrementUpdate : public TraitBase<ConcreteOp, PushDownIncrementUpdate> {};
 
 } // namespace mlir::OpTrait
 

src/ir/daphneir/DaphnePushDownTraits.td

@@ -19,7 +19,11 @@
 
 include "mlir/IR/OpBase.td"
 
+// ============================================================================
+// Traits determining pushdown rewrite possibilities
+// ============================================================================
+
 def PushDownLinear: NativeOpTrait<"PushDownLinear">;
-def PushDownWithIntervalUpdate: NativeOpTrait<"PushDownWithIntervalUpdate">;
+def PushDownIncrementUpdate: NativeOpTrait<"PushDownIncrementUpdate">;
 
 #endif //SRC_IR_DAPHNEIR_DAPHNEPUSHDOWNTRAITS_TD

workspace/minus.daphne

@@ -0,0 +1,3 @@
+
+b = - rand(1,3,-6,-3,1.0,7);
+print(b);