Skip to content

Commit 702501c

Browse files
author
Pablo Mendez
committed
add check falsy value
1 parent 4ff64db commit 702501c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/db/src/updatePkgsWithGlobalEnvs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export async function updatePkgsWithGlobalEnvs(globalEnvKey: string, globEnvValu
3838
const currentVal = serviceEnvs[globalEnvKey];
3939
if (currentVal === globEnvValue) {
4040
logs.info(`Global env ${globalEnvKey} for ${pkg.dnpName} already set to ${globEnvValue}, skipping update`);
41-
} else if (!currentVal && !globEnvValue) {
41+
} else if (!currentVal && (!globEnvValue || globEnvValue === "false")) {
4242
// empty strings are determined as false values within packages. Dappmanager 0.2.103 and below sets glob envs bool false values as empty strings
4343
logs.info(`Global env ${globalEnvKey} for ${pkg.dnpName} already nullish, skipping update`);
4444
} else {

0 commit comments

Comments
 (0)