Skip to content

Commit cc8e8f0

Browse files
authored
Add test for aliases util function (#1739)
* Add test for getting private network aliases * Remove "only" test
1 parent c702590 commit cc8e8f0

File tree

2 files changed

+47
-2
lines changed

2 files changed

+47
-2
lines changed

packages/utils/src/buildNetworkAlias.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import { getShortUniqueDnp } from "./getShortUniqueDnp.js";
22

3-
// TODO: unit testing
4-
53
/**
64
* This function return fullNetworkAlias or shortNetworkAlias:
75
* - shortDnpName is dnpName.split(0)["."]. i.e dnpName = "dappmanager.dnp.dappnode.eth" => shortDnpName = "dappmanager"
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
import { expect } from "chai";
2+
import { getPrivateNetworkAliases } from "../../src/index.js";
3+
import { params } from "@dappnode/params";
4+
5+
describe("getPrivateNetworkAliases", () => {
6+
it("should always return full network alias", () => {
7+
const container = {
8+
dnpName: "example.dnp.dappnode.eth",
9+
serviceName: "service",
10+
isMainOrMonoservice: false
11+
};
12+
const result = getPrivateNetworkAliases(container);
13+
expect(result).to.include("service.example.dappnode");
14+
});
15+
16+
it("should return short network alias for main or monoservice containers", () => {
17+
const container = {
18+
dnpName: "example.dnp.dappnode.eth",
19+
serviceName: "service",
20+
isMainOrMonoservice: true
21+
};
22+
const result = getPrivateNetworkAliases(container);
23+
expect(result).to.include.members(["service.example.dappnode", "example.dappnode"]);
24+
});
25+
26+
it("should include special aliases for the Admin UI", () => {
27+
const container = {
28+
dnpName: params.dappmanagerDnpName,
29+
serviceName: "dappmanager",
30+
isMainOrMonoservice: true
31+
};
32+
const result = getPrivateNetworkAliases(container);
33+
expect(result).to.include.members(["dappmanager.dappmanager.dappnode", "dappmanager.dappnode", ...params.DAPPMANAGER_ALIASES]);
34+
});
35+
36+
it("should ensure uniqueness of aliases", () => {
37+
const container = {
38+
dnpName: "example.dnp.dappnode.eth",
39+
serviceName: "example",
40+
isMainOrMonoservice: true
41+
};
42+
const result = getPrivateNetworkAliases(container);
43+
const uniqueResult = [...new Set(result)];
44+
expect(result).to.have.lengthOf(uniqueResult.length);
45+
});
46+
47+
});

0 commit comments

Comments
 (0)