fix swr render when data is false

Author: Pablo Mendez

packages/admin-ui/src/components/SwrRender.tsx

@@ -8,7 +8,8 @@ export function renderResponse<T>(
   loadingMessages: string[],
   onData: (data: T) => React.ReactElement
 ): React.ReactElement | null {
-  if (res.data) return onData(res.data);
+  // res.data might be false, so we check if it exists or is not undefined
+  if (res.data || res.data !== undefined) return onData(res.data);
   if (res.error) return <ErrorView error={res.error} />;
   if (res.isValidating) return <Loading steps={loadingMessages} />;
   return null;

packages/admin-ui/src/pages/notifications/NotificationsRoot.tsx

@@ -12,10 +12,9 @@ import { NotificationsSettings } from "./tabs/Settings/Settings";
 import { LegacyNotifications } from "./tabs/Legacy";
 
 export const NotificationsRoot: React.FC = () => {
-  const dnpsRequest = useApi.packagesGet();
-  return renderResponse(dnpsRequest, ["Loading notifications"], () => {
-  const isNotificationsPkgInstalled = useApi.notificationsIsInstalled();
+  const isNotificationsPkgInstalledRequest = useApi.notificationsIsInstalled();
 
+  return renderResponse(isNotificationsPkgInstalledRequest, ["Loading notifications"], (isInstalled) => {
     const availableRoutes: {
       name: string;
       subPath: string;
@@ -24,12 +23,12 @@ export const NotificationsRoot: React.FC = () => {
       {
         name: "Inbox",
         subPath: subPaths.inbox,
-        component: isNotificationsPkgInstalled.data ? Inbox : () => <InstallNotificationsPkg />
+        component: isInstalled ? Inbox : () => <InstallNotificationsPkg />
       },
       {
         name: "Settings",
         subPath: subPaths.settings,
-        component: isNotificationsPkgInstalled.data ? NotificationsSettings : () => <InstallNotificationsPkg />
+        component: isInstalled ? NotificationsSettings : () => <InstallNotificationsPkg />
       },
       {
         name: "Legacy",