fix get latest version (#852)

Signed-off-by: Mukundan Sundararajan <[email protected]>

Author: mukundansundar

pkg/version/version.go

@@ -21,6 +21,7 @@ import (
 	"os"
 	"strings"
 
+	"github.com/hashicorp/go-version"
 	yaml "gopkg.in/yaml.v2"
 
 	"github.com/dapr/cli/pkg/print"
@@ -110,13 +111,23 @@ func GetLatestReleaseGithub(githubURL string) (string, error) {
 			return "", fmt.Errorf("no releases")
 		}
 
+		defaultVersion, _ := version.NewVersion("0.0.0")
+		latestVersion := defaultVersion
+
 		for _, release := range githubRepoReleases {
 			if !strings.Contains(release.TagName, "-rc") {
-				return strings.TrimPrefix(release.TagName, "v"), nil
+				cur, _ := version.NewVersion(strings.TrimPrefix(release.TagName, "v"))
+				if cur.GreaterThan(latestVersion) {
+					latestVersion = cur
+				}
 			}
 		}
 
-		return "", fmt.Errorf("no releases")
+		if latestVersion.Equal(defaultVersion) {
+			return "", fmt.Errorf("no releases")
+		}
+
+		return latestVersion.String(), nil
 	})
 }
 

pkg/version/version_test.go

@@ -61,6 +61,74 @@ func TestGetVersionsGithub(t *testing.T) {
 			"",
 			"1.2.2",
 		},
+		{
+			"Only latest version is got",
+			"/latest",
+			`[
+  {
+    "url": "https://api.github.com/repos/dapr/dapr/releases/44766923",
+    "html_url": "https://github.com/dapr/dapr/releases/tag/v1.4.4",
+    "id": 44766926,
+    "tag_name": "v1.4.4",
+    "target_commitish": "master",
+    "name": "Dapr Runtime v1.4.4",
+    "draft": false,
+    "prerelease": false
+  },
+  {
+    "url": "https://api.github.com/repos/dapr/dapr/releases/44766923",
+    "html_url": "https://github.com/dapr/dapr/releases/tag/v1.5.1",
+    "id": 44766923,
+    "tag_name": "v1.5.1",
+    "target_commitish": "master",
+    "name": "Dapr Runtime v1.5.1",
+    "draft": false,
+    "prerelease": false
+  }
+]
+			`,
+			"",
+			"1.5.1",
+		},
+		{
+			"Only latest stable version is got",
+			"/latest_stable",
+			`[
+  {
+    "url": "https://api.github.com/repos/dapr/dapr/releases/44766923",
+    "html_url": "https://github.com/dapr/dapr/releases/tag/v1.5.2-rc.1",
+    "id": 44766926,
+    "tag_name": "v1.5.2-rc.1",
+    "target_commitish": "master",
+    "name": "Dapr Runtime v1.5.2-rc.1",
+    "draft": false,
+    "prerelease": true
+  },
+  {
+    "url": "https://api.github.com/repos/dapr/dapr/releases/44766923",
+    "html_url": "https://github.com/dapr/dapr/releases/tag/v1.4.4",
+    "id": 44766926,
+    "tag_name": "v1.4.4",
+    "target_commitish": "master",
+    "name": "Dapr Runtime v1.4.4",
+    "draft": false,
+    "prerelease": false
+  },
+  {
+    "url": "https://api.github.com/repos/dapr/dapr/releases/44766923",
+    "html_url": "https://github.com/dapr/dapr/releases/tag/v1.5.1",
+    "id": 44766923,
+    "tag_name": "v1.5.1",
+    "target_commitish": "master",
+    "name": "Dapr Runtime v1.5.1",
+    "draft": false,
+    "prerelease": false
+  }
+]
+			`,
+			"",
+			"1.5.1",
+		},
 		{
 			"Malformed JSON",
 			"/malformed",