You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* use non-deprecated flags in List operation (#1478)
Signed-off-by: yaron2 <schneider.yaron@live.com>
* Scheduler: set broadcast address to localhost:50006 in selfhosted (#1480)
* Scheduler: set broadcast address to localhost:50006 in selfhosted
Signed-off-by: joshvanl <me@joshvanl.dev>
* Set schedulder override flag for edge and dev
Signed-off-by: joshvanl <me@joshvanl.dev>
---------
Signed-off-by: joshvanl <me@joshvanl.dev>
* Fix scheduler broadcast address for windows (#1481)
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Remove deprecated flags (#1482)
* remove deprecated flags
Signed-off-by: yaron2 <schneider.yaron@live.com>
* update Dapr version in tests
Signed-off-by: yaron2 <schneider.yaron@live.com>
---------
Signed-off-by: yaron2 <schneider.yaron@live.com>
* Fix daprsystem configuration retrieval when renewing certificates (#1486)
The issue found when similar resource were installed in k8s that use the name "configurations".
In this case the knative's "configurations.serving.knative.dev/v1" was the last in the list and the command returned the error
`Error from server (NotFound): configurations.serving.knative.dev "daprsystem" not found`
Signed-off-by: Anton Troshin <anton@diagrid.io>
* fix: arguments accept units (#1490)
* fix: arguments accept units
`max-body-size` and `read-buffer-size` now accept units as defined in the docs.
Fixes#1489
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: modify logic to comply with vetting
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt -w .
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: set defaults
`max-body-size` is defaulted to 4Mi
`request-buffer-size` is defaulted to 4Ki
This is inline with the runtime.
Signed-off-by: Mike Nguyen <hey@mike.ee>
* fix: set defaults in run and annotate
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: exit with error rather than panic
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
Signed-off-by: Mike Nguyen <hey@mike.ee>
---------
Signed-off-by: Mike Nguyen <hey@mike.ee>
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
* Fix scheduler pod count for 1.15 version when testing master and latest (#1492)
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Fix podman CI (#1493)
* Fix podman CI
Update to podman 5.4.0
Signed-off-by: Anton Troshin <anton@diagrid.io>
* fix --cpus flag
Signed-off-by: Anton Troshin <anton@diagrid.io>
---------
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Fix dapr upgrade command incorrectly detecting HA mode for new version 1.15 (#1494)
* Fix dapr upgrade command detecting HA mode for new version 1.15
The issue is that the scheduler by default uses 3 replicas, which incorrectly identified non-HA install as HA.
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Fix e2e
Signed-off-by: Anton Troshin <anton@diagrid.io>
---------
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Fix scheduler address for dapr run with file on Windows (#1497)
Signed-off-by: Anton Troshin <anton@diagrid.io>
* release: test upgrade/downgrade for 1.13/1.14/1.15 + mariner (#1491)
* release: test upgrade/downgrade for 1.13/1.14/1.15 + mariner
Signed-off-by: Mike Nguyen <hey@mike.ee>
* fix: version skews
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
Signed-off-by: Mike Nguyen <hey@mike.ee>
* Update tests/e2e/upgrade/upgrade_test.go
Accepted
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
Signed-off-by: Yaron Schneider <schneider.yaron@live.com>
* Update tests/e2e/upgrade/upgrade_test.go
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
Signed-off-by: Yaron Schneider <schneider.yaron@live.com>
* Fix downgrade issue from 1.15 by deleting previous version scheduler pods
Update 1.15 RC to latest RC.18
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Fix downgrade 1.15 to 1.13 scenario with 0 scheduler pods
Signed-off-by: Anton Troshin <anton@diagrid.io>
* increase update test timeout to 60m and update latest version to 1.15
Signed-off-by: Anton Troshin <anton@diagrid.io>
* fix httpendpoint tests cleanup and checks
Signed-off-by: Anton Troshin <anton@diagrid.io>
* make sure matrix runs appropriate tests, every matrix ran the same tests
Signed-off-by: Anton Troshin <anton@diagrid.io>
* skip TestKubernetesRunFile on HA
Signed-off-by: Anton Troshin <anton@diagrid.io>
* fix skip TestKubernetesRunFile on HA
Signed-off-by: Anton Troshin <anton@diagrid.io>
* update to latest dapr 1.15.2
Signed-off-by: Anton Troshin <anton@diagrid.io>
* add logs when waiting for pod deletion
Signed-off-by: Anton Troshin <anton@diagrid.io>
---------
Signed-off-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: Anton Troshin <anton@diagrid.io>
Co-authored-by: Anton Troshin <anton@diagrid.io>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
* Fix dapr init test latest version retrieval (#1500)
Lint
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Fix downgrade stuck (#1501)
* Fix goroutine channel leaks and ensure proper cleanup in tests
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Add artificial delay before deleting scheduler pods during downgrade
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Add timeout to helm upgrade tests, they are being stuck sometime for 5+ minutes
Signed-off-by: Anton Troshin <anton@diagrid.io>
* bump helm.sh/helm/v3 to v3.17.1
Signed-off-by: Anton Troshin <anton@diagrid.io>
---------
Signed-off-by: Anton Troshin <anton@diagrid.io>
---------
Signed-off-by: yaron2 <schneider.yaron@live.com>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: Anton Troshin <anton@diagrid.io>
Signed-off-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev>
Co-authored-by: Mike Nguyen <hey@mike.ee>
AnnotateCmd.Flags().StringVar(&annotateDaprImage, "dapr-image", "", "The image to use for the dapr sidecar container")
386
402
AnnotateCmd.Flags().BoolVar(&annotateAppSSL, "app-ssl", false, "Enable SSL for the app")
387
403
AnnotateCmd.Flags().MarkDeprecated("app-ssl", "This flag is deprecated and will be removed in a future release. Use \"app-protocol\" flag with https or grpcs instead")
388
-
AnnotateCmd.Flags().IntVar(&annotateMaxRequestBodySize, "max-request-body-size", -1, "The maximum request body size to use")
389
-
AnnotateCmd.Flags().IntVar(&annotateReadBufferSize, "http-read-buffer-size", -1, "The maximum size of HTTP header read buffer in kilobytes")
404
+
AnnotateCmd.Flags().StringVar(&annotateMaxRequestBodySize, "max-body-size", strconv.Itoa(runtime.DefaultMaxRequestBodySize>>20)+"Mi", "The maximum request body size to use")
405
+
AnnotateCmd.Flags().StringVar(&annotateReadBufferSize, "read-buffer-size", strconv.Itoa(runtime.DefaultReadBufferSize>>10)+"Ki", "The maximum size of HTTP header read buffer in kilobytes")
390
406
AnnotateCmd.Flags().BoolVar(&annotateHTTPStreamRequestBody, "http-stream-request-body", false, "Enable streaming request body for HTTP")
391
407
AnnotateCmd.Flags().IntVar(&annotateGracefulShutdownSeconds, "graceful-shutdown-seconds", -1, "The number of seconds to wait for the app to shutdown")
392
408
AnnotateCmd.Flags().BoolVar(&annotateEnableAPILogging, "enable-api-logging", false, "Enable API logging for the Dapr sidecar")
Copy file name to clipboardExpand all lines: cmd/run.go
+9-7Lines changed: 9 additions & 7 deletions
Original file line number
Diff line number
Diff line change
@@ -29,6 +29,8 @@ import (
29
29
"github.com/spf13/cobra"
30
30
"github.com/spf13/viper"
31
31
32
+
daprRuntime "github.com/dapr/dapr/pkg/runtime"
33
+
32
34
"github.com/dapr/cli/pkg/kubernetes"
33
35
"github.com/dapr/cli/pkg/metadata"
34
36
"github.com/dapr/cli/pkg/print"
@@ -55,8 +57,8 @@ var (
55
57
resourcesPaths []string
56
58
appSSLbool
57
59
metricsPortint
58
-
maxRequestBodySizeint
59
-
readBufferSizeint
60
+
maxRequestBodySizestring
61
+
readBufferSizestring
60
62
unixDomainSocketstring
61
63
enableAppHealthbool
62
64
appHealthPathstring
@@ -473,8 +475,8 @@ func init() {
473
475
RunCmd.Flags().MarkDeprecated("app-ssl", "This flag is deprecated and will be removed in the future releases. Use \"app-protocol\" flag with https or grpcs values instead")
474
476
RunCmd.Flags().IntVarP(&metricsPort, "metrics-port", "M", -1, "The port of metrics on dapr")
475
477
RunCmd.Flags().BoolP("help", "h", false, "Print this help message")
476
-
RunCmd.Flags().IntVarP(&maxRequestBodySize, "dapr-http-max-request-size", "", -1, "Max size of request body in MB")
477
-
RunCmd.Flags().IntVarP(&readBufferSize, "dapr-http-read-buffer-size", "", -1, "HTTP header read buffer in KB")
478
+
RunCmd.Flags().StringVarP(&maxRequestBodySize, "max-body-size", "", strconv.Itoa(daprRuntime.DefaultMaxRequestBodySize>>20)+"Mi", "Max size of request body in MB")
479
+
RunCmd.Flags().StringVarP(&readBufferSize, "read-buffer-size", "", strconv.Itoa(daprRuntime.DefaultReadBufferSize>>10)+"Ki", "HTTP header read buffer in KB")
478
480
RunCmd.Flags().StringVarP(&unixDomainSocket, "unix-domain-socket", "u", "", "Path to a unix domain socket dir. If specified, Dapr API servers will use Unix Domain Sockets")
479
481
RunCmd.Flags().BoolVar(&enableAppHealth, "enable-app-health-check", false, "Enable health checks for the application using the protocol defined with app-protocol")
480
482
RunCmd.Flags().StringVar(&appHealthPath, "app-health-check-path", "", "Path used for health checks; HTTP only")
0 commit comments