Skip to content

Commit 2c3a2cd

Browse files
LKIMukundan Sundararajanyaron2
authored andcommitted
feat: support windows style delimiter (#834)
- related to #779 Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: imneov <[email protected]>
1 parent bcf8f1a commit 2c3a2cd

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pkg/kubernetes/client.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"fmt"
1919
"os"
2020
"path/filepath"
21+
"runtime"
2122
"strings"
2223
"sync"
2324

@@ -40,8 +41,6 @@ import (
4041
"k8s.io/client-go/tools/clientcmd"
4142
)
4243

43-
const kubeConfigDelimiter = ":"
44-
4544
var (
4645
doOnce sync.Once
4746
kubeconfig *string
@@ -60,6 +59,10 @@ func getConfig() (*rest.Config, error) {
6059
flag.Parse()
6160
})
6261
kubeConfigEnv := os.Getenv("KUBECONFIG")
62+
kubeConfigDelimiter := ":"
63+
if runtime.GOOS == "windows" {
64+
kubeConfigDelimiter = ";"
65+
}
6366
delimiterBelongsToPath := strings.Count(*kubeconfig, kubeConfigDelimiter) == 1 && strings.EqualFold(*kubeconfig, kubeConfigEnv)
6467

6568
if len(kubeConfigEnv) != 0 && !delimiterBelongsToPath {

0 commit comments

Comments
 (0)