Skip to content

Commit 5a624af

Browse files
committed
fix review comment and failing merge
Signed-off-by: Pravin Pushkar <[email protected]>
1 parent 03d190a commit 5a624af

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/standalone/common.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ func emptyAndCopyFiles(src, dest string) error {
8282
return err
8383
}
8484
for _, file := range files {
85-
err = os.Remove(dest + "/" + file.Name())
85+
err = os.Remove(path_filepath.Join(dest, file.Name()))
8686
if err != nil {
8787
return err
8888
}
@@ -94,12 +94,12 @@ func emptyAndCopyFiles(src, dest string) error {
9494
if len(files) > 0 {
9595
print.InfoStatusEvent(os.Stdout, "Moving files from %q to %q", src, dest)
9696
for _, file := range files {
97-
content, err := os.ReadFile(src + "/" + file.Name())
97+
content, err := os.ReadFile(path_filepath.Join(src, file.Name()))
9898
if err != nil {
9999
return err
100100
}
101101
// #nosec G306
102-
err = os.WriteFile(dest+"/"+file.Name(), content, 0o644)
102+
err = os.WriteFile(path_filepath.Join(dest, file.Name()), content, 0o644)
103103
if err != nil {
104104
return err
105105
}

tests/e2e/standalone/upgrade_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func copyInMemStateStore(t *testing.T) {
7979
}
8080

8181
func initTest(t *testing.T) {
82-
daprRuntimeVersion, _ := common.GetVersionsFromEnv(t)
82+
daprRuntimeVersion, _ := common.GetVersionsFromEnv(t, false)
8383

8484
output, err := cmdInit(daprRuntimeVersion)
8585
t.Log(output)

0 commit comments

Comments
 (0)