fix: test failures

Signed-off-by: nelson.parente <nelson_parente@live.com.pt>

Author: nelson-parente

cmd/components.go

@@ -42,7 +42,7 @@ var ComponentsCmd = &cobra.Command{
 			}
 			err := kubernetes.PrintComponents(componentsName, resourceNamespace, componentsOutputFormat)
 			if err != nil {
-				print.FailureStatusEvent(os.Stderr, err.Error())
+				print.FailureStatusEvent(os.Stderr, "%s", err.Error())
 				os.Exit(1)
 			}
 		}

pkg/kubernetes/kubernetes.go

@@ -122,7 +122,7 @@ func Init(config InitConfiguration) error {
 }
 
 func installThirdPartyWithConsole(releaseName, chartName, releaseVersion, helmRepo string, prettyName string, chartValues []string, config InitConfiguration) error {
-	installSpinning := print.Spinner(os.Stdout, "Deploying the "+prettyName+" with "+releaseVersion+" version to your cluster...")
+	installSpinning := print.Spinner(os.Stdout, "Deploying the %s with %s version to your cluster...", prettyName, releaseVersion)
 	defer installSpinning(print.Failure)
 
 	// releaseVersion of chart will always be latest version.
@@ -136,7 +136,7 @@ func installThirdPartyWithConsole(releaseName, chartName, releaseVersion, helmRe
 }
 
 func installWithConsole(releaseName, releaseVersion, helmRepo string, prettyName string, config InitConfiguration) error {
-	installSpinning := print.Spinner(os.Stdout, "Deploying the "+prettyName+" with "+releaseVersion+" version to your cluster...")
+	installSpinning := print.Spinner(os.Stdout, "Deploying the %s with %s version to your cluster...", prettyName, releaseVersion)
 	defer installSpinning(print.Failure)
 
 	err := install(releaseName, releaseVersion, helmRepo, config)

tests/e2e/kubernetes/run_template_test.go

@@ -153,7 +153,7 @@ func startAppsWithTemplateFile(t *testing.T, runFilePath string) {
 		"-k",
 	}
 	output, err := cmdRun(args...)
-	t.Logf(output)
+	t.Logf("%s", output)
 	require.NoError(t, err, "run failed")
 	assert.Contains(t, output, "Deploying service YAML")
 	assert.Contains(t, output, "Deploying deployment YAML")

tests/e2e/standalone/run_template_test.go

@@ -61,7 +61,7 @@ func TestRunWithTemplateFile(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
 		output, err := cmdRunWithContext(ctx, "", args...)
-		t.Logf(output)
+		t.Logf("%s", output)
 		require.NoError(t, err, "run failed")
 		// Deterministic output for template file, so we can assert line by line
 		lines := strings.Split(output, "\n")
@@ -110,7 +110,7 @@ func TestRunWithTemplateFile(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
 		output, err := cmdRunWithContext(ctx, "", args...)
-		t.Logf(output)
+		t.Logf("%s", output)
 		require.NoError(t, err, "run failed")
 		// Deterministic output for template file, so we can assert line by line
 		lines := strings.Split(output, "\n")
@@ -166,7 +166,7 @@ func TestRunWithTemplateFile(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
 		output, err := cmdRunWithContext(ctx, "", args...)
-		t.Logf(output)
+		t.Logf("%s", output)
 		require.NoError(t, err, "run failed")
 		// Deterministic output for template file, so we can assert line by line
 		lines := strings.Split(output, "\n")
@@ -216,7 +216,7 @@ func TestRunWithTemplateFile(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
 		output, err := cmdRunWithContext(ctx, "", args...)
-		t.Logf(output)
+		t.Logf("%s", output)
 		require.NoError(t, err, "run failed")
 		// Deterministic output for template file, so we can assert line by line
 		lines := strings.Split(output, "\n")
@@ -267,7 +267,7 @@ func TestRunWithTemplateFile(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
 		output, err := cmdRunWithContext(ctx, "", args...)
-		t.Logf(output)
+		t.Logf("%s", output)
 		require.Error(t, err, "run must fail")
 		// Deterministic output for template file, so we can assert line by line
 		lines := strings.Split(output, "\n")
@@ -315,7 +315,7 @@ func TestRunWithTemplateFile(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
 		output, err := cmdRunWithContext(ctx, "", args...)
-		t.Logf(output)
+		t.Logf("%s", output)
 		require.NoError(t, err, "run failed")
 
 		// App logs for processor app should not be printed to console and only written to file.
@@ -374,7 +374,7 @@ func TestRunTemplateFileWithoutDaprInit(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
 		output, err := cmdRunWithContext(ctx, "", args...)
-		t.Logf(output)
+		t.Logf("%s", output)
 		require.Error(t, err, "run must fail")
 		assert.Contains(t, output, "Error starting Dapr and app (\"processor\"): fork/exec")
 		assert.Contains(t, output, "daprd: no such file or directory")

tests/e2e/standalone/windows_run_template_test.go

@@ -78,7 +78,7 @@ func startAppsWithValidRunTemplate(t *testing.T, file string) {
 		"-f", file,
 	}
 	output, err := cmdRun("", args...)
-	t.Logf(output)
+	t.Logf("%s", output)
 	require.NoError(t, err, "run failed")
 	lines := strings.Split(output, "\n")
 	assert.GreaterOrEqual(t, len(lines), 6, "expected at least 6 lines in output of starting two apps")
@@ -97,7 +97,7 @@ func startAppsWithAppLogDestFile(t *testing.T, file string) {
 		"-f", file,
 	}
 	output, err := cmdRun("", args...)
-	t.Logf(output)
+	t.Logf("%s", output)
 	require.NoError(t, err, "run failed")
 
 	// App logs for processor app should not be printed to console and only written to file.
@@ -120,7 +120,7 @@ func startAppsWithAppLogDestConsole(t *testing.T, file string) {
 		"-f", file,
 	}
 	output, err := cmdRun("", args...)
-	t.Logf(output)
+	t.Logf("%s", output)
 	require.NoError(t, err, "run failed")
 
 	// App logs for processor app should be printed to console.