Skip to content

Commit d4654c0

Browse files
Add e2e timeout to Dockerhub runs and update Makefile default (#1159)
* Fix e2e test timeout Signed-off-by: Shubham Sharma <[email protected]> * Revert unwanted change due to formatting Signed-off-by: Shubham Sharma <[email protected]> * Override makefile Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]>
1 parent 53dff40 commit d4654c0

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.github/workflows/self_hosted_e2e.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ jobs:
132132
env:
133133
DAPR_E2E_INIT_SLIM: ${{ contains(matrix.os, 'windows-latest') || contains(matrix.dapr_install_mode, 'slim') }}
134134
CONTAINER_RUNTIME: ${{ env.CONTAINER_RUNTIME }}
135+
E2E_SH_TEST_TIMEOUT: ${{ env.E2E_SH_TEST_TIMEOUT }}
135136
run: |
136137
export TEST_OUTPUT_FILE=$GITHUB_WORKSPACE/test-e2e-standalone.json
137138
echo "TEST_OUTPUT_FILE=$TEST_OUTPUT_FILE" >> $GITHUB_ENV

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ export GOOS ?= $(TARGET_OS_LOCAL)
7070
export BINARY_EXT ?= $(BINARY_EXT_LOCAL)
7171

7272
TEST_OUTPUT_FILE ?= test_output.json
73-
E2E_SH_TEST_TIMEOUT ?= 10m
73+
74+
# Set the default timeout for tests to 10 minutes
75+
ifndef E2E_SH_TEST_TIMEOUT
76+
override E2E_SH_TEST_TIMEOUT := 10m
77+
endif
7478

7579
# Use the variable H to add a header (equivalent to =>) to informational output
7680
H = $(shell printf "\033[34;1m=>\033[0m")

0 commit comments

Comments
 (0)