Skip to content

Commit 77cb485

Browse files
sicoyleJoshVanL
andauthored
fix: make bool defaults as a string (#3989)
Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: joshvanl <[email protected]> Co-authored-by: joshvanl <[email protected]>
1 parent bbca991 commit 77cb485

File tree

33 files changed

+159
-162
lines changed

33 files changed

+159
-162
lines changed

.build-tools/pkg/metadataschema/schema.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ type ComponentMetadata struct {
2020
// Version of the component metadata schema.
2121
SchemaVersion string `json:"schemaVersion" yaml:"schemaVersion" jsonschema:"enum=v1"`
2222
// Component type, of one of the allowed values.
23-
Type string `json:"type" yaml:"type" jsonschema:"enum=bindings,enum=state,enum=secretstores,enum=pubsub,enum=workflows,enum=configuration,enum=lock,enum=middleware,enum=crypto,enum=conversation"`
23+
Type string `json:"type" yaml:"type" jsonschema:"enum=bindings,enum=state,enum=secretstores,enum=pubsub,enum=workflows,enum=configuration,enum=lock,enum=middleware,enum=crypto,enum=nameresolution,enum=conversation"`
2424
// Name of the component (without the inital type, e.g. "http" instead of "bindings.http").
2525
Name string `json:"name" yaml:"name"`
2626
// Version of the component, with the leading "v", e.g. "v1".

bindings/apns/metadata.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ authenticationProfiles:
3333
description: "The APNS private key (P8 file content)"
3434
metadata:
3535
- name: development
36-
type: boolean
36+
type: bool
3737
required: false
3838
description: "The APNS environment is development or not"
39-
example: true
40-
default: false
39+
example: "true"
40+
default: "false"

bindings/kubemq/metadata.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,20 +37,20 @@ metadata:
3737
description: The KubeMQ channel name.
3838
example: "my-channel"
3939
- name: pollMaxItems
40-
type: int
40+
type: number
4141
required: false
4242
description: The maximum number of items to poll.
43-
example: 10
44-
default: 1
43+
example: "10"
44+
default: "1"
4545
- name: pollTimeoutSeconds
46-
type: int
46+
type: number
4747
required: false
4848
description: The timeout in seconds for polling.
49-
example: 3600
50-
default: 3600
49+
example: "3600"
50+
default: "3600"
5151
- name: autoAcknowledged
5252
type: bool
5353
required: false
5454
description: Whether to automatically acknowledge messages.
55-
example: true
56-
default: false
55+
example: "true"
56+
default: "false"

bindings/mqtt3/metadata.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@ metadata:
5050
- name: retain
5151
required: false
5252
description: "Whether to retain messages"
53-
example: false
54-
default: false
53+
example: "false"
54+
default: "false"
5555
- name: cleanSession
5656
required: false
5757
description: "Whether to use clean session"
58-
example: true
59-
default: true
58+
example: "true"
59+
default: "true"
6060
- name: backOffMaxRetries
6161
required: false
6262
description: "Maximum retries for backoff"

bindings/rethinkdb/statechange/metadata.yaml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ authenticationProfiles:
5151
type: bool
5252
required: false
5353
description: Whether to enable TLS encryption.
54-
example: false
55-
default: false
54+
example: "false"
55+
default: "false"
5656
- name: clientCert
5757
type: string
5858
required: true
@@ -75,8 +75,8 @@ metadata:
7575
type: bool
7676
required: false
7777
description: Whether to archive changes to a separate table.
78-
example: false
79-
default: false
78+
example: "false"
79+
default: "false"
8080
- name: timeout
8181
type: string
8282
required: false
@@ -86,13 +86,13 @@ metadata:
8686
type: bool
8787
required: false
8888
description: Whether to use json.Number instead of float64.
89-
example: false
90-
default: false
89+
example: "false"
90+
default: "false"
9191
- name: numRetries
9292
type: number
9393
required: false
9494
description: Number of times to retry queries on connection errors.
95-
example: 3
95+
example: "3"
9696
- name: hostDecayDuration
9797
type: string
9898
required: false
@@ -103,8 +103,8 @@ metadata:
103103
type: bool
104104
required: false
105105
description: Whether to enable opentracing for queries.
106-
example: false
107-
default: false
106+
example: "false"
107+
default: "false"
108108
- name: writeTimeout
109109
type: string
110110
required: false
@@ -119,7 +119,7 @@ metadata:
119119
type: number
120120
required: false
121121
description: Handshake version for RethinkDB."
122-
example: 1
122+
example: "1"
123123
- name: keepAlivePeriod
124124
type: string
125125
required: false
@@ -129,7 +129,7 @@ metadata:
129129
type: number
130130
required: false
131131
description: Maximum number of idle connections."
132-
example: 5
132+
example: "5"
133133
- name: authKey
134134
type: string
135135
required: false
@@ -140,17 +140,17 @@ metadata:
140140
type: number
141141
required: false
142142
description: Initial connection pool capacity."
143-
example: 5
143+
example: "5"
144144
- name: maxOpen
145145
type: number
146146
required: false
147147
description: Maximum number of open connections."
148-
example: 10
148+
example: "10"
149149
- name: discoverHosts
150150
type: bool
151151
required: false
152152
description: Whether to discover hosts."
153-
example: false
153+
example: "false"
154154
- name: nodeRefreshInterval
155155
type: string
156156
required: false

bindings/sftp/metadata.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,5 +75,5 @@ metadata:
7575
- name: insecureIgnoreHostKey
7676
required: false
7777
description: "Skip host key verification (insecure)"
78-
example: false
79-
default: false
78+
example: "false"
79+
default: "false"

bindings/smtp/metadata.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,5 +66,5 @@ metadata:
6666
- name: skipTLSVerify
6767
required: false
6868
description: "Skip TLS verification"
69-
example: false
70-
default: false
69+
example: "false"
70+
default: "false"

bindings/wasm/metadata.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ metadata:
1818
- name: strictSandbox
1919
required: false
2020
description: "Strict sandbox mode. When true, uses fake sources to avoid vulnerabilities such as timing attacks."
21-
example: true
22-
default: false
21+
example: "true"
22+
default: "false"
2323
- name: url
2424
required: true
2525
description: "The URL of the WASM file"

component-metadata-schema.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@
214214
"lock",
215215
"middleware",
216216
"crypto",
217+
"nameresolution",
217218
"conversation"
218219
],
219220
"description": "Component type, of one of the allowed values."

crypto/azure/keyvault/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# yaml-language-server: $schema=../../../component-metadata-schema.json
22
schemaVersion: v1
3-
type: cryptography
3+
type: crypto
44
name: azure.keyvault
55
version: v1
66
status: alpha

0 commit comments

Comments
 (0)