fix: Return all values

Signed-off-by: Javier Aliaga <[email protected]>

Author: javier-aliaga

.github/scripts/test-info.mjs

@@ -874,13 +874,14 @@ const components = {
  * Returns the list of components for the matrix.
  * @param {'conformance'|'certification'} testKind Kind of test
  * @param {boolean} enableCloudTests If true, returns components that require secrets or credentials too (which can't be used as part of the regular CI in a PR)
+ * @param {string} pattern If present, returns components includes the pattern
  * @returns {TestMatrixElement[]} Test matrix object
  */
-function GenerateMatrix(testKind, enableCloudTests) {
+function GenerateMatrix(testKind, enableCloudTests, pattern) {
     /** @type {TestMatrixElement[]} */
     const res = []
     for (const name in components) {
-        if (!name.includes('dynamodb') ){
+        if (pattern && !name.includes(pattern) ){
             continue
         }
         const comp = components[name]
@@ -966,7 +967,8 @@ if (argv.length < 4 || !['true', 'false'].includes(argv[3])) {
 
 const testKind = argv[2]
 const enableCloudTests = argv[3] == 'true'
-const matrixObj = GenerateMatrix(testKind, enableCloudTests)
+const pattern = argv[4] || ''
+const matrixObj = GenerateMatrix(testKind, enableCloudTests, pattern)
 console.log('Generated matrix:\n\n' + JSON.stringify(matrixObj, null, '  '))
 
 writeFileSync(env.GITHUB_OUTPUT, 'test-matrix=' + JSON.stringify(matrixObj))

state/aws/dynamodb/dynamodb.go

@@ -478,9 +478,6 @@ func (d *StateStore) Multi(ctx context.Context, request *state.TransactionalStat
 				return fmt.Errorf("dynamodb error: failed to marshal value for key %s: %w", req.Key, err)
 			}
 			twi.Put = pd.ToPut()
-			if twi.Put.ConditionExpression != nil {
-				twi.ConditionCheck.ReturnValuesOnConditionCheckFailure = types.ReturnValuesOnConditionCheckFailureAllOld
-			}
 		case state.DeleteRequest:
 			twi.Delete = &types.Delete{
 				TableName: ptr.Of(d.table),

tests/certification/state/aws/dynamodb/dynamodb_test.go

@@ -134,18 +134,12 @@ func TestAWSDynamoDBStorage(t *testing.T) {
 			defer cl.Close()
 
 			ktx1 := "reqKeyTx1"
-			ktx2 := "reqKeyTx2"
+			//ktx2 := "reqKeyTx2"
 			kdel := "reqKey2"
 
 			err = cl.SaveState(ctx, statestore, kdel, []byte(kdel), nil)
 			require.NoError(t, err)
 
-			err = cl.DeleteState(ctx, statestore, ktx1, nil)
-			require.NoError(t, err)
-
-			err = cl.DeleteState(ctx, statestore, ktx2, nil)
-			require.NoError(t, err)
-
 			err = cl.ExecuteStateTransaction(ctx, statestore, nil, []*client.StateOperation{
 				{
 					Type: client.StateOperationTypeUpsert,
@@ -158,32 +152,32 @@ func TestAWSDynamoDBStorage(t *testing.T) {
 						Metadata: map[string]string{},
 					},
 				},
-				{
-					Type: client.StateOperationTypeDelete,
-					Item: &client.SetStateItem{
-						Key:      kdel,
-						Metadata: map[string]string{},
-					},
-				},
-				{
-					Type: client.StateOperationTypeUpsert,
-					Item: &client.SetStateItem{
-						Key:   ktx2,
-						Value: []byte("reqValTx2"),
-						Etag: &client.ETag{
-							Value: "test",
-						},
-						Metadata: map[string]string{},
-					},
-				},
+				//{
+				//	Type: client.StateOperationTypeDelete,
+				//	Item: &client.SetStateItem{
+				//		Key:      kdel,
+				//		Metadata: map[string]string{},
+				//	},
+				//},
+				//{
+				//	Type: client.StateOperationTypeUpsert,
+				//	Item: &client.SetStateItem{
+				//		Key:   ktx2,
+				//		Value: []byte("reqValTx2"),
+				//		Etag: &client.ETag{
+				//			Value: "test",
+				//		},
+				//		Metadata: map[string]string{},
+				//	},
+				//},
 			})
 			require.NoError(t, err)
 
 			err = cl.DeleteState(ctx, statestore, ktx1, nil)
 			require.NoError(t, err)
 
-			err = cl.DeleteState(ctx, statestore, ktx2, nil)
-			require.NoError(t, err)
+			//err = cl.DeleteState(ctx, statestore, ktx2, nil)
+			//require.NoError(t, err)
 
 			return nil
 		}