Skip to content

Commit 478053b

Browse files
committed
refactor: address reviewer feedback on subscription.py
- Split subscribe_message_bindings into focused helper functions - Add module-level constants for delivery modes and status codes - Use WorkflowStatus enum instead of magic strings - Add proper validation for dead_letter_topics (ValueError if multiple) - Fix _resolve_event_loop to properly raise on missing loop - Add zombie thread detection (raise RuntimeError on timeout) - Move json import to top level - Rename variables for clarity: - grouped -> bindings_by_topic_key - b -> binding - plan -> binding_schema_pairs - preferred -> matching_ce_type_pairs - Replace logger.info with logger.debug for internal operations - Restore underscore prefixes for internal functions - Remove nested try/except where possible - Add proper docstrings explaining function purposes Signed-off-by: Arush Wadhawan <warush23+github@gmail.com>
1 parent 4d2fcf1 commit 478053b

File tree

2 files changed

+454
-263
lines changed

2 files changed

+454
-263
lines changed

dapr_agents/workflow/utils/registration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
DedupeBackend,
2626
MessageRouteBinding,
2727
SchedulerFn,
28-
resolve_loop,
28+
_resolve_event_loop,
2929
subscribe_message_bindings,
3030
)
3131

@@ -192,7 +192,7 @@ def _mount_http_bindings(
192192
if not bindings:
193193
return []
194194

195-
_ = resolve_loop(
195+
_ = _resolve_event_loop(
196196
loop
197197
) # Parity with message registrar; FastAPI does not require it yet.
198198
closers: List[Callable[[], None]] = []

0 commit comments

Comments
 (0)