Skip to content

fix: minor glitches in quickstart 01#357

Merged
sicoyle merged 2 commits intodapr:mainfrom
xverges:xv-quickstart-01-glitches
Jan 16, 2026
Merged

fix: minor glitches in quickstart 01#357
sicoyle merged 2 commits intodapr:mainfrom
xverges:xv-quickstart-01-glitches

Conversation

@xverges
Copy link
Contributor

@xverges xverges commented Jan 11, 2026

Description

  • Clarified how to use a different LLM provider in quickstarts/01-dapr-agents-fundamentals/README.md
  • Made explicit a parameter's default value (expected by the code and the Optional type) that raised a
    typing error.
  • Made consistent with its file name the session_id parameter of ConversationDaprStateMemory
  • Fixed 07_durable_agent_pubsub.py, that was exiting before the user had a chance to publish a task.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR closes: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Created/updated tests
  • Tested this change against all the quickstarts
  • Extended the documentation

Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.

@xverges xverges requested review from a team as code owners January 11, 2026 18:59
Copy link
Contributor

@CasperGN CasperGN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xverges - LGTM 🚀

sicoyle
sicoyle previously approved these changes Jan 12, 2026
Copy link
Collaborator

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙌

@sicoyle
Copy link
Collaborator

sicoyle commented Jan 12, 2026

Hi 👋 Any chance you could rebase onto the latest main? We recently added 3.14 as a build step, which is now in main. I also merged an older PR today that unfortunately introduced some conflicts on your branch. Your changes are next in my mental merge queue 😄 Thanks!

Signed-off-by: Xavier Vergés <github@verg.es>
@xverges
Copy link
Contributor Author

xverges commented Jan 12, 2026

Done! :-)

Copy link
Collaborator

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@sicoyle sicoyle merged commit 8606fd9 into dapr:main Jan 16, 2026
6 checks passed
@xverges xverges deleted the xv-quickstart-01-glitches branch January 16, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants