Refactored to make deserialization for GetJobAsync testable. Added unit test to validate reported customer issue. (#1497)

Signed-off-by: Whit Waldo <[email protected]>

Author: WhitWaldo

src/Dapr.Jobs/DaprJobsGrpcClient.cs

@@ -163,17 +163,7 @@ public override async Task<DaprJobDetails> GetJobAsync(string jobName, Cancellat
             var envelope = new Autogenerated.GetJobRequest { Name = jobName };
             var grpcCallOptions = DaprClientUtilities.ConfigureGrpcCallOptions(typeof(DaprJobsClient).Assembly, this.DaprApiToken, cancellationToken);
             var response = await Client.GetJobAlpha1Async(envelope, grpcCallOptions);
-            var schedule = DateTime.TryParse(response.Job.DueTime, out var dueTime)
-                ? DaprJobSchedule.FromDateTime(dueTime)
-                : new DaprJobSchedule(response.Job.Schedule);
-                
-            return new DaprJobDetails(schedule)
-            {
-                DueTime = !string.IsNullOrWhiteSpace(response.Job.DueTime) ? DateTime.Parse(response.Job.DueTime) : null,
-                Ttl = !string.IsNullOrWhiteSpace(response.Job.Ttl) ? DateTime.Parse(response.Job.Ttl) : null,
-                RepeatCount = (int?)response.Job.Repeats,
-                Payload = response.Job.Data.ToByteArray()
-            };
+            return DeserializeJobResponse(response);
         }
         catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested)
         {
@@ -192,6 +182,29 @@ public override async Task<DaprJobDetails> GetJobAsync(string jobName, Cancellat
         throw new DaprException("Get job operation failed: the Dapr endpoint did not return the expected value.");
     }
 
+    /// <summary>
+    /// Testable method for performing job response deserialization.
+    /// </summary>
+    /// <remarks>
+    /// This is exposed strictly for testing purposes.
+    /// </remarks>
+    /// <param name="response">The job response to deserialize.</param>
+    /// <returns>The deserialized job response.</returns>
+    internal static DaprJobDetails DeserializeJobResponse(Autogenerated.GetJobResponse response)
+    {
+        var schedule = DateTime.TryParse(response.Job.DueTime, out var dueTime)
+            ? DaprJobSchedule.FromDateTime(dueTime)
+            : new DaprJobSchedule(response.Job.Schedule);
+                
+        return new DaprJobDetails(schedule)
+        {
+            DueTime = !string.IsNullOrWhiteSpace(response.Job.DueTime) ? DateTime.Parse(response.Job.DueTime) : null,
+            Ttl = !string.IsNullOrWhiteSpace(response.Job.Ttl) ? DateTime.Parse(response.Job.Ttl) : null,
+            RepeatCount = (int?)response.Job.Repeats ?? 0,
+            Payload = response.Job.Data?.ToByteArray() ?? null
+        };
+    }
+
     /// <summary>
     /// Deletes the specified job.
     /// </summary>

test/Dapr.Jobs.Test/DaprJobsGrpcClientTests.cs

@@ -13,6 +13,7 @@
 
 using System;
 using System.Net.Http;
+using Dapr.Client.Autogen.Grpc.v1;
 using Dapr.Jobs.Models;
 using Moq;
 using Xunit;
@@ -167,6 +168,21 @@ public void DeleteJobAsync_NameCannotBeEmpty()
         });
 #pragma warning restore CS0618 // Type or member is obsolete
     }
+    
+    [Fact]
+    public void ShouldDeserialize_EveryExpression()
+    {
+        const string scheduleText = "@every 1m";
+        var response = new GetJobResponse { Job = new Job { Name = "test", Schedule = scheduleText } };
+        var schedule = DaprJobSchedule.FromExpression(scheduleText);
+        
+        var jobDetails = DaprJobsGrpcClient.DeserializeJobResponse(response);
+        Assert.Null(jobDetails.Payload);
+        Assert.Equal(0, jobDetails.RepeatCount);
+        Assert.Null(jobDetails.Ttl);
+        Assert.Null(jobDetails.DueTime);
+        Assert.Equal(jobDetails.Schedule.ExpressionValue, schedule.ExpressionValue);
+    }
 
     private sealed record TestPayload(string Name, string Color);
 }