Skip to content

Commit c99475b

Browse files
authored
[Workflow] Fix issue with ignored external event payload (#1119)
* [Workflow] Fix issue with ignored external event payload Signed-off-by: Chris Gillum <[email protected]> * Pushing missing commits Signed-off-by: Chris Gillum <[email protected]> * Remove unnecessary steps from itests.yml Signed-off-by: Chris Gillum <[email protected]> --------- Signed-off-by: Chris Gillum <[email protected]>
1 parent 8e9db70 commit c99475b

File tree

3 files changed

+9
-19
lines changed

3 files changed

+9
-19
lines changed

.github/workflows/itests.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -105,16 +105,6 @@ jobs:
105105
- uses: actions/checkout@v1
106106
- name: Parse release version
107107
run: python ./.github/scripts/get_release_version.py
108-
- name: Install Local kafka using docker-compose
109-
run: |
110-
docker-compose -f test/Dapr.E2E.Test/deploy/local-test-kafka.yml up -d
111-
docker ps
112-
- name: Install Local Hashicorp Vault using docker-compose
113-
run: |
114-
docker-compose -f test/Dapr.E2E.Test/deploy/local-test-vault.yml up -d
115-
docker ps
116-
- name: Setup Vault's test token
117-
run: echo myroot > /tmp/.hashicorp_vault_token
118108
- name: Setup ${{ matrix.display-name }}
119109
uses: actions/setup-dotnet@v1
120110
with:

src/Dapr.Workflow/Dapr.Workflow.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
<PackageId>Dapr.Workflow</PackageId>
88
<Title>Dapr Workflow Authoring SDK</Title>
99
<Description>Dapr Workflow SDK for building workflows as code with Dapr</Description>
10-
<VersionPrefix>0.2.0</VersionPrefix>
10+
<VersionPrefix>0.3.0</VersionPrefix>
1111
<VersionSuffix>alpha</VersionSuffix>
1212
<LangVersion>10.0</LangVersion>
1313
</PropertyGroup>
1414

1515
<ItemGroup>
16-
<PackageReference Include="Microsoft.DurableTask.Client.Grpc" Version="1.0.0" />
17-
<PackageReference Include="Microsoft.DurableTask.Worker.Grpc" Version="1.0.0" />
16+
<PackageReference Include="Microsoft.DurableTask.Client.Grpc" Version="1.0.*" />
17+
<PackageReference Include="Microsoft.DurableTask.Worker.Grpc" Version="1.0.*" />
1818
</ItemGroup>
1919

2020
<ItemGroup>

src/Dapr.Workflow/DaprWorkflowClient.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ public Task<string> ScheduleNewWorkflowAsync(
7070
/// <param name="instanceId">The unique ID of the workflow instance to fetch.</param>
7171
/// <param name="getInputsAndOutputs">
7272
/// Specify <c>true</c> to fetch the workflow instance's inputs, outputs, and custom status, or <c>false</c> to
73-
/// omit them. Defaults to false.
73+
/// omit them. Defaults to true.
7474
/// </param>
75-
public async Task<WorkflowState> GetWorkflowStateAsync(string instanceId, bool getInputsAndOutputs = false)
75+
public async Task<WorkflowState> GetWorkflowStateAsync(string instanceId, bool getInputsAndOutputs = true)
7676
{
7777
OrchestrationMetadata? metadata = await this.innerClient.GetInstancesAsync(
7878
instanceId,
@@ -94,7 +94,7 @@ public async Task<WorkflowState> GetWorkflowStateAsync(string instanceId, bool g
9494
/// <param name="instanceId">The unique ID of the workflow instance to wait for.</param>
9595
/// <param name="getInputsAndOutputs">
9696
/// Specify <c>true</c> to fetch the workflow instance's inputs, outputs, and custom status, or <c>false</c> to
97-
/// omit them. The default value is <c>false</c> to minimize the network bandwidth, serialization, and memory costs
97+
/// omit them. Setting this value to <c>false</c> can help minimize the network bandwidth, serialization, and memory costs
9898
/// associated with fetching the instance metadata.
9999
/// </param>
100100
/// <param name="cancellation">A <see cref="CancellationToken"/> that can be used to cancel the wait operation.</param>
@@ -104,7 +104,7 @@ public async Task<WorkflowState> GetWorkflowStateAsync(string instanceId, bool g
104104
/// </returns>
105105
public async Task<WorkflowState> WaitForWorkflowStartAsync(
106106
string instanceId,
107-
bool getInputsAndOutputs = false,
107+
bool getInputsAndOutputs = true,
108108
CancellationToken cancellation = default)
109109
{
110110
OrchestrationMetadata metadata = await this.innerClient.WaitForInstanceStartAsync(
@@ -135,7 +135,7 @@ public async Task<WorkflowState> WaitForWorkflowStartAsync(
135135
/// <inheritdoc cref="WaitForWorkflowStartAsync(string, bool, CancellationToken)"/>
136136
public async Task<WorkflowState> WaitForWorkflowCompletionAsync(
137137
string instanceId,
138-
bool getInputsAndOutputs = false,
138+
bool getInputsAndOutputs = true,
139139
CancellationToken cancellation = default)
140140
{
141141
OrchestrationMetadata metadata = await this.innerClient.WaitForInstanceCompletionAsync(
@@ -218,7 +218,7 @@ public Task RaiseEventAsync(
218218
object? eventPayload = null,
219219
CancellationToken cancellation = default)
220220
{
221-
return this.innerClient.RaiseEventAsync(instanceId, eventName, cancellation);
221+
return this.innerClient.RaiseEventAsync(instanceId, eventName, eventPayload, cancellation);
222222
}
223223

224224
/// <summary>

0 commit comments

Comments
 (0)