Skip to content

Commit e7a71c4

Browse files
shivamkm07halspang
andauthored
removing Obsolete attribute from config API classes (#1098)
Signed-off-by: Shivam Kumar <[email protected]> Co-authored-by: halspang <[email protected]>
1 parent a3e5106 commit e7a71c4

File tree

10 files changed

+1
-15
lines changed

10 files changed

+1
-15
lines changed

examples/Client/ConfigurationApi/Controllers/ConfigurationController.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ namespace ConfigurationApi.Controllers
1313
{
1414
[ApiController]
1515
[Route("configuration")]
16-
[Obsolete]
1716
public class ConfigurationController : ControllerBase
1817
{
1918
private ILogger<ConfigurationController> logger;

examples/Client/ConfigurationApi/Program.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using Microsoft.AspNetCore.Hosting;
33
using Microsoft.Extensions.Hosting;
44
using Dapr.Client;
@@ -10,7 +10,6 @@ namespace ConfigurationApi
1010
{
1111
public class Program
1212
{
13-
[Obsolete]
1413
public static void Main(string[] args)
1514
{
1615
Console.WriteLine("Starting application.");

src/Dapr.Client/DaprClient.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -907,7 +907,6 @@ public abstract Task<Dictionary<string, Dictionary<string, string>>> GetBulkSecr
907907
/// <param name="metadata">Optional metadata that will be sent to the configuration store being queried.</param>
908908
/// <param name="cancellationToken">A <see cref="CancellationToken" /> that can be used to cancel the operation.</param>
909909
/// <returns>A <see cref="Task"/> containing a <see cref="GetConfigurationResponse"/></returns>
910-
[Obsolete("This API is currently not stable as it is in the Alpha stage. This attribute will be removed once it is stable.")]
911910
public abstract Task<GetConfigurationResponse> GetConfiguration(
912911
string storeName,
913912
IReadOnlyList<string> keys,
@@ -922,7 +921,6 @@ public abstract Task<GetConfigurationResponse> GetConfiguration(
922921
/// <param name="metadata">Optional metadata that will be sent to the configuration store being queried.</param>
923922
/// <param name="cancellationToken">A <see cref="CancellationToken" /> that can be used to cancel the operation.</param>
924923
/// <returns>A <see cref="SubscribeConfigurationResponse"/> which contains a reference to the stream.</returns>
925-
[Obsolete("This API is currently not stable as it is in the Alpha stage. This attribute will be removed once it is stable.")]
926924
public abstract Task<SubscribeConfigurationResponse> SubscribeConfiguration(
927925
string storeName,
928926
IReadOnlyList<string> keys,
@@ -936,7 +934,6 @@ public abstract Task<SubscribeConfigurationResponse> SubscribeConfiguration(
936934
/// <param name="id">The Id of the subscription that should no longer be watched.</param>
937935
/// <param name="cancellationToken">A <see cref="CancellationToken" /> that can be used to cancel the operation.</param>
938936
/// <returns></returns>
939-
[Obsolete("This API is currently not stable as it is in the Alpha stage. This attribute will be removed once it is stable.")]
940937
public abstract Task<UnsubscribeConfigurationResponse> UnsubscribeConfiguration(
941938
string storeName,
942939
string id,

src/Dapr.Client/DaprClientGrpc.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,7 +1286,6 @@ public async override Task<Dictionary<string, Dictionary<string, string>>> GetBu
12861286

12871287
#region Configuration API
12881288
/// <inheritdoc/>
1289-
[Obsolete]
12901289
public async override Task<GetConfigurationResponse> GetConfiguration(
12911290
string storeName,
12921291
IReadOnlyList<string> keys,
@@ -1330,7 +1329,6 @@ public async override Task<GetConfigurationResponse> GetConfiguration(
13301329
}
13311330

13321331
/// <inheritdoc/>
1333-
[Obsolete]
13341332
public override Task<SubscribeConfigurationResponse> SubscribeConfiguration(
13351333
string storeName,
13361334
IReadOnlyList<string> keys,
@@ -1361,7 +1359,6 @@ public override Task<SubscribeConfigurationResponse> SubscribeConfiguration(
13611359
return Task.FromResult(new SubscribeConfigurationResponse(new DaprSubscribeConfigurationSource(client.SubscribeConfiguration(request, options))));
13621360
}
13631361

1364-
[Obsolete]
13651362
public override async Task<UnsubscribeConfigurationResponse> UnsubscribeConfiguration(
13661363
string storeName,
13671364
string id,

src/Dapr.Client/SubscribeConfigurationResponse.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ namespace Dapr.Client
66
/// <summary>
77
/// Response for a Subscribe Configuration request.
88
/// </summary>
9-
[Obsolete("This response utilizes an alpha API which is subject to change. This attribute will be removed when the API is no longer Alpha.")]
109
public class SubscribeConfigurationResponse
1110
{
1211
private ConfigurationSource source;

src/Dapr.Extensions.Configuration/DaprConfigurationStoreExtension.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ namespace Dapr.Extensions.Configuration
2222
/// <summary>
2323
/// Extension used to call the Dapr Configuration API and store the values in a <see cref="IConfiguration"/>.
2424
/// </summary>
25-
[Obsolete]
2625
public static class DaprConfigurationStoreExtension
2726
{
2827
/// <summary>

src/Dapr.Extensions.Configuration/DaprConfigurationStoreProvider.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ namespace Dapr.Extensions.Configuration
2424
/// A configuration provider that utilizes the Dapr Configuration API. It can either be a single, constant
2525
/// call or a streaming call.
2626
/// </summary>
27-
[Obsolete]
2827
internal class DaprConfigurationStoreProvider : ConfigurationProvider, IDisposable
2928
{
3029
private string store;

src/Dapr.Extensions.Configuration/DaprConfigurationStoreSource.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ namespace Dapr.Extensions.Configuration
2222
/// <summary>
2323
/// Configuration source that provides a <see cref="DaprConfigurationStoreProvider"/>.
2424
/// </summary>
25-
[Obsolete]
2625
public class DaprConfigurationStoreSource : IConfigurationSource
2726
{
2827
/// <summary>

test/Dapr.Client.Test/ConfigurationApiTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
namespace Dapr.Client.Test
2222
{
23-
[System.Obsolete]
2423
public class ConfigurationApiTest
2524
{
2625
[Fact]

test/Dapr.Client.Test/ConfigurationSourceTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
namespace Dapr.Client.Test
1111
{
12-
[Obsolete]
1312
public class ConfigurationSourceTest
1413
{
1514
private readonly string StoreName = "testStore";

0 commit comments

Comments
 (0)