Merge pull request #27 from famarting/optional-skip-wait-for-instance-start

grpc api: optional skip wait for instance start

Author: JoshVanL

backend/executor.go

@@ -49,15 +49,16 @@ type Executor interface {
 type grpcExecutor struct {
 	protos.UnimplementedTaskHubSidecarServiceServer
 
-	workItemQueue        chan *protos.WorkItem
-	pendingOrchestrators *sync.Map // map[api.InstanceID]*ExecutionResults
-	pendingActivities    *sync.Map // map[string]*activityExecutionResult
-	backend              Backend
-	logger               Logger
-	onWorkItemConnection func(context.Context) error
-	onWorkItemDisconnect func(context.Context) error
-	streamShutdownChan   <-chan any
-	streamSendTimeout    *time.Duration
+	workItemQueue            chan *protos.WorkItem
+	pendingOrchestrators     *sync.Map // map[api.InstanceID]*ExecutionResults
+	pendingActivities        *sync.Map // map[string]*activityExecutionResult
+	backend                  Backend
+	logger                   Logger
+	onWorkItemConnection     func(context.Context) error
+	onWorkItemDisconnect     func(context.Context) error
+	streamShutdownChan       <-chan any
+	streamSendTimeout        *time.Duration
+	skipWaitForInstanceStart bool
 }
 
 type grpcExecutorOptions func(g *grpcExecutor)
@@ -98,6 +99,12 @@ func WithStreamSendTimeout(d time.Duration) grpcExecutorOptions {
 	}
 }
 
+func WithSkipWaitForInstanceStart() grpcExecutorOptions {
+	return func(g *grpcExecutor) {
+		g.skipWaitForInstanceStart = true
+	}
+}
+
 // NewGrpcExecutor returns the Executor object and a method to invoke to register the gRPC server in the executor.
 func NewGrpcExecutor(be Backend, logger Logger, opts ...grpcExecutorOptions) (executor Executor, registerServerFn func(grpcServer grpc.ServiceRegistrar)) {
 	grpcExecutor := &grpcExecutor{
@@ -506,12 +513,14 @@ func (g *grpcExecutor) StartInstance(ctx context.Context, req *protos.CreateInst
 		},
 	}
 	if err := g.backend.CreateOrchestrationInstance(ctx, e, WithOrchestrationIdReusePolicy(req.OrchestrationIdReusePolicy)); err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to create orchestration instance: %w", err)
 	}
 
-	_, err := g.WaitForInstanceStart(ctx, &protos.GetInstanceRequest{InstanceId: instanceID})
-	if err != nil {
-		return nil, err
+	if !g.skipWaitForInstanceStart {
+		_, err := g.WaitForInstanceStart(ctx, &protos.GetInstanceRequest{InstanceId: instanceID})
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	return &protos.CreateInstanceResponse{InstanceId: instanceID}, nil