chore: Rename method to be go-idiomatic (#32)

Signed-off-by: Javier Aliaga <[email protected]>

Author: javier-aliaga

samples/taskexecutionid/taskexecutionid.go

@@ -115,8 +115,8 @@ func getCounter(taskExecutionId string) *atomic.Int32 {
 }
 
 func RandomFailActivity(ctx task.ActivityContext) (any, error) {
-	log.Println(fmt.Sprintf("#### [%v] activity %v failure", ctx.GetTaskExecutionId(), ctx.GetTaskID()))
-	counter := getCounter(ctx.GetTaskExecutionId())
+	log.Println(fmt.Sprintf("#### [%v] activity %v failure", ctx.GetTaskExecutionID(), ctx.GetTaskID()))
+	counter := getCounter(ctx.GetTaskExecutionID())
 	// The activity should fail 5 times before succeeding.
 	if counter.Load() != 5 {
 		log.Println("random activity failure")

task/activity.go

@@ -105,13 +105,13 @@ func WithActivityRetryPolicy(policy *RetryPolicy) callActivityOption {
 type ActivityContext interface {
 	GetInput(resultPtr any) error
 	GetTaskID() int32
-	GetTaskExecutionId() string
+	GetTaskExecutionID() string
 	Context() context.Context
 }
 
 type activityContext struct {
 	TaskID          int32
-	TaskExecutionId string
+	TaskExecutionID string
 	Name            string
 
 	rawInput []byte
@@ -124,7 +124,7 @@ type Activity func(ctx ActivityContext) (any, error)
 func newTaskActivityContext(ctx context.Context, taskID int32, ts *protos.TaskScheduledEvent) *activityContext {
 	return &activityContext{
 		TaskID:          taskID,
-		TaskExecutionId: ts.TaskExecutionId,
+		TaskExecutionID: ts.TaskExecutionId,
 		Name:            ts.Name,
 		rawInput:        []byte(ts.Input.GetValue()),
 		ctx:             ctx,
@@ -144,6 +144,6 @@ func (actx *activityContext) GetTaskID() int32 {
 	return actx.TaskID
 }
 
-func (actx *activityContext) GetTaskExecutionId() string {
-	return actx.TaskExecutionId
+func (actx *activityContext) GetTaskExecutionID() string {
+	return actx.TaskExecutionID
 }

tests/orchestrations_test.go

@@ -1346,7 +1346,7 @@ func Test_TaskExecutionId(t *testing.T) {
 	t.Run("SingleActivityWithRetry", func(t *testing.T) {
 		// Registration
 		r := task.NewTaskRegistry()
-		require.NoError(t, r.AddOrchestratorN("TaskExecutionId", func(ctx *task.OrchestrationContext) (any, error) {
+		require.NoError(t, r.AddOrchestratorN("TaskExecutionID", func(ctx *task.OrchestrationContext) (any, error) {
 			if err := ctx.CallActivity("FailActivity", task.WithActivityRetryPolicy(&task.RetryPolicy{
 				MaxAttempts:          3,
 				InitialRetryInterval: 10 * time.Millisecond,
@@ -1359,7 +1359,7 @@ func Test_TaskExecutionId(t *testing.T) {
 		executionMap := make(map[string]int)
 		var executionId string
 		require.NoError(t, r.AddActivityN("FailActivity", func(ctx task.ActivityContext) (any, error) {
-			executionId = ctx.GetTaskExecutionId()
+			executionId = ctx.GetTaskExecutionID()
 			executionMap[executionId]++
 			if executionMap[executionId] == 3 {
 				return nil, nil
@@ -1374,7 +1374,7 @@ func Test_TaskExecutionId(t *testing.T) {
 		defer worker.Shutdown(ctx)
 
 		// Run the orchestration
-		id, err := client.ScheduleNewOrchestration(ctx, "TaskExecutionId")
+		id, err := client.ScheduleNewOrchestration(ctx, "TaskExecutionID")
 		require.NoError(t, err)
 
 		metadata, err := client.WaitForOrchestrationCompletion(ctx, id)
@@ -1391,7 +1391,7 @@ func Test_TaskExecutionId(t *testing.T) {
 	t.Run("ParallelActivityWithRetry", func(t *testing.T) {
 		// Registration
 		r := task.NewTaskRegistry()
-		require.NoError(t, r.AddOrchestratorN("TaskExecutionId", func(ctx *task.OrchestrationContext) (any, error) {
+		require.NoError(t, r.AddOrchestratorN("TaskExecutionID", func(ctx *task.OrchestrationContext) (any, error) {
 			t1 := ctx.CallActivity("FailActivity", task.WithActivityRetryPolicy(&task.RetryPolicy{
 				MaxAttempts:          3,
 				InitialRetryInterval: 10 * time.Millisecond,
@@ -1421,8 +1421,8 @@ func Test_TaskExecutionId(t *testing.T) {
 		require.NoError(t, r.AddActivityN("FailActivity", func(ctx task.ActivityContext) (any, error) {
 			lock.Lock()
 			defer lock.Unlock()
-			executionMap[ctx.GetTaskExecutionId()] = executionMap[ctx.GetTaskExecutionId()] + 1
-			if executionMap[ctx.GetTaskExecutionId()] == 3 {
+			executionMap[ctx.GetTaskExecutionID()] = executionMap[ctx.GetTaskExecutionID()] + 1
+			if executionMap[ctx.GetTaskExecutionID()] == 3 {
 				return nil, nil
 			}
 			return nil, errors.New("activity failure")
@@ -1435,7 +1435,7 @@ func Test_TaskExecutionId(t *testing.T) {
 		defer worker.Shutdown(ctx)
 
 		// Run the orchestration
-		id, err := client.ScheduleNewOrchestration(ctx, "TaskExecutionId")
+		id, err := client.ScheduleNewOrchestration(ctx, "TaskExecutionID")
 		require.NoError(t, err)
 
 		metadata, err := client.WaitForOrchestrationCompletion(ctx, id)
@@ -1456,7 +1456,7 @@ func Test_TaskExecutionId(t *testing.T) {
 	t.Run("SingleActivityWithNoRetry", func(t *testing.T) {
 		// Registration
 		r := task.NewTaskRegistry()
-		require.NoError(t, r.AddOrchestratorN("TaskExecutionId", func(ctx *task.OrchestrationContext) (any, error) {
+		require.NoError(t, r.AddOrchestratorN("TaskExecutionID", func(ctx *task.OrchestrationContext) (any, error) {
 			if err := ctx.CallActivity("Activity").Await(nil); err != nil {
 				return nil, err
 			}
@@ -1465,7 +1465,7 @@ func Test_TaskExecutionId(t *testing.T) {
 
 		var executionId string
 		require.NoError(t, r.AddActivityN("Activity", func(ctx task.ActivityContext) (any, error) {
-			executionId = ctx.GetTaskExecutionId()
+			executionId = ctx.GetTaskExecutionID()
 			return nil, nil
 		}))
 
@@ -1476,7 +1476,7 @@ func Test_TaskExecutionId(t *testing.T) {
 		defer worker.Shutdown(ctx)
 
 		// Run the orchestration
-		id, err := client.ScheduleNewOrchestration(ctx, "TaskExecutionId")
+		id, err := client.ScheduleNewOrchestration(ctx, "TaskExecutionID")
 		require.NoError(t, err)
 
 		metadata, err := client.WaitForOrchestrationCompletion(ctx, id)