Skip to content

Commit 2f417d0

Browse files
committed
deprecate java 8, use java 11 to align with java-sdk
Signed-off-by: Cassandra Coyle <[email protected]>
1 parent 2c5c5a3 commit 2f417d0

File tree

5 files changed

+26
-26
lines changed

5 files changed

+26
-26
lines changed

.github/workflows/build-validation.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,6 @@ jobs:
2525
uses: actions/setup-java@v2
2626
with:
2727
java-version: '11'
28-
distribution: 'microsoft'
29-
30-
- name: set JDK_11 environment variable test compiling and running
31-
env:
32-
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
33-
run: echo ::set-env name=JDK_11::$(echo $JAVA_HOME)
34-
35-
- name: Set up JDK 8
36-
uses: actions/setup-java@v2
37-
with:
38-
java-version: '8'
3928
distribution: 'temurin'
4029

4130
- name: Setup Gradle
@@ -57,7 +46,6 @@ jobs:
5746

5847
- name: Run Unit Tests with Gradle
5948
run: |
60-
export JAVA_HOME=$JDK_11
6149
./gradlew clean test || echo "UNIT_TEST_FAILED=true" >> $GITHUB_ENV
6250
continue-on-error: true
6351

CONTRIBUTING.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,21 @@ Build & test:
99
./gradlew build
1010
```
1111

12+
## Verify Build Components
13+
14+
To ensure all build components work correctly after making changes:
15+
16+
```shell
17+
# Build without tests
18+
./gradlew build -x test
19+
20+
# Run unit tests
21+
./gradlew test
22+
23+
# Run SpotBugs
24+
./gradlew spotbugsMain
25+
```
26+
1227
## Updating Protobuf Definitions
1328

1429
When updating the protobuf definitions in `internal/durabletask-protobuf/protos/orchestrator_service.proto`:

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@
55

66
This repo contains the Java SDK for the Durable Task Framework as well as classes and annotations to support running [Azure Durable Functions](https://docs.microsoft.com/azure/azure-functions/durable/durable-functions-overview?tabs=java) for Java. With this SDK, you can define, schedule, and manage durable orchestrations using ordinary Java code.
77

8+
## Requirements
9+
10+
- **Java 11 or higher** - This SDK requires Java 11 as the minimum version
11+
- **Gradle** - The project uses [Gradle 7.6.4](gradle/wrapper/gradle-wrapper.properties)
12+
813
### Simple, fault-tolerant sequences
914

1015
```java

azurefunctions/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ In this article, you follow steps to create and run a simple azure durable funct
66

77
The following are the requirements for you local environment:
88

9-
- The Java Developer Kit, version 8 or 11, is required. Between the two, JDK 11 is recommended.
9+
- The Java Developer Kit, version 11 or higher, is required.
1010
- The `JAVA_HOME` environment variable must be set to the install location of the correct version of the JDK.
1111
- [Apache Maven](https://maven.apache.org/), version 3.0 or above for azure function app creation, is required for using automatic project creation tools.
1212
- If Maven isn't your preferred development tool, check out our similar tutorials to [create a function app](https://docs.microsoft.com/en-us/azure/azure-functions/create-first-function-cli-java?tabs=bash%2Cazure-cli%2Cbrowser). This README also contains instructions for [Gradle](https://gradle.org/).

client/build.gradle

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,7 @@ archivesBaseName = 'durabletask-client'
1717
def grpcVersion = '1.69.0'
1818
def protocVersion = '3.25.5'
1919
def jacksonVersion = '2.15.3'
20-
// When build on local, you need to set this value to your local jdk11 directory.
21-
// Java11 is used to compile and run all the tests.
22-
// Example for Windows: C:/Program Files/Java/openjdk-11.0.12_7/
23-
def PATH_TO_TEST_JAVA_RUNTIME = System.env.JDK_11 ?: System.getProperty("java.home")
20+
// Java 11 is now the minimum required version for both compilation and testing
2421

2522
dependencies {
2623

@@ -53,18 +50,17 @@ dependencies {
5350
testImplementation 'io.netty:netty-handler:4.1.119.Final'
5451
testImplementation "io.netty:netty-tcnative-boringssl-static:2.0.59.Final"
5552

56-
testImplementation 'org.bouncycastle:bcprov-jdk15on:1.78'
53+
testImplementation 'org.bouncycastle:bcprov-jdk15on:1.70'
54+
testImplementation 'org.bouncycastle:bcpkix-jdk15on:1.70'
5755
}
5856

5957
compileJava {
60-
sourceCompatibility = JavaVersion.VERSION_1_8
61-
targetCompatibility = JavaVersion.VERSION_1_8
58+
sourceCompatibility = JavaVersion.VERSION_11
59+
targetCompatibility = JavaVersion.VERSION_11
6260
}
6361
compileTestJava {
6462
sourceCompatibility = JavaVersion.VERSION_11
6563
targetCompatibility = JavaVersion.VERSION_11
66-
options.fork = true
67-
options.forkOptions.executable = "${PATH_TO_TEST_JAVA_RUNTIME}/bin/javac"
6864
}
6965

7066
task downloadProtoFiles {
@@ -115,10 +111,6 @@ sourceSets {
115111
}
116112
}
117113

118-
tasks.withType(Test) {
119-
executable = new File("${PATH_TO_TEST_JAVA_RUNTIME}", 'bin/java')
120-
}
121-
122114
test {
123115
useJUnitPlatform {
124116
// Skip tests tagged as "integration" since those are slower

0 commit comments

Comments
 (0)