Merge pull request #21 from salaboy/fix-log-format

cicoyle · web-flow · commit 4677216194bc · 2025-05-28T10:44:34.000-05:00
Fixing formatting in logs, when using retries this log was not working
diff --git a/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java b/client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java
@@ -1188,7 +1188,7 @@ private boolean shouldRetry() {
             }
 
             private boolean shouldRetryBasedOnPolicy() {
-                logger.warning(this.attemptNumber + " retries out of total %d performed " + this.policy.getMaxNumberOfAttempts());
+                logger.warning(() -> String.format("%d retries out of total %d performed ", this.attemptNumber, this.policy.getMaxNumberOfAttempts()));
 
                 if (this.attemptNumber >= this.policy.getMaxNumberOfAttempts()) {
                     // Max number of attempts exceeded

Original file line number	Diff line number	Diff line change
`@@ -1188,7 +1188,7 @@ private boolean shouldRetry() {`
`1188`	`1188`	`}`
`1189`	`1189`
`1190`	`1190`	`private boolean shouldRetryBasedOnPolicy() {`
`1191`		`- logger.warning(this.attemptNumber + " retries out of total %d performed " + this.policy.getMaxNumberOfAttempts());`
	`1191`	`+ logger.warning(() -> String.format("%d retries out of total %d performed ", this.attemptNumber, this.policy.getMaxNumberOfAttempts()));`
`1192`	`1192`
`1193`	`1193`	`if (this.attemptNumber >= this.policy.getMaxNumberOfAttempts()) {`
`1194`	`1194`	`// Max number of attempts exceeded`