Add tests to explicit naming of workflows/activities

Revert changes on the anonymous function detection.

Author: tscolari

workflow/worker.go

@@ -20,7 +20,6 @@ import (
 	"fmt"
 	"log"
 	"reflect"
-	"regexp"
 	"runtime"
 	"strings"
 
@@ -93,13 +92,7 @@ func getFunctionName(f interface{}) (string, error) {
 	callSplit := strings.Split(runtime.FuncForPC(reflect.ValueOf(f).Pointer()).Name(), ".")
 	funcName := callSplit[len(callSplit)-1]
 
-	const anonymousFunctionRegexp = "^func[0-9]+$"
-	isAnonymousFunc, err := regexp.MatchString(anonymousFunctionRegexp, funcName)
-	if err != nil {
-		return "", fmt.Errorf("failed to match anonymous function regexp: %w", err)
-	}
-
-	if isAnonymousFunc {
+	if funcName == "1" {
 		return "", errors.New("anonymous function name")
 	}
 

workflow/worker_test.go

@@ -43,22 +43,46 @@ func TestWorkflowRuntime(t *testing.T) {
 	t.Run("register workflow", func(t *testing.T) {
 		err := testWorker.RegisterWorkflow(testWorkflow)
 		require.NoError(t, err)
+
+		t.Run("with explicit name", func(t *testing.T) {
+			err := testWorker.RegisterWorkflow(testWorkflow, RegisterWithName("MyWorkflow"))
+			require.NoError(t, err)
+		})
 	})
 	t.Run("register workflow - anonymous func", func(t *testing.T) {
 		err := testWorker.RegisterWorkflow(func(ctx *WorkflowContext) (any, error) {
 			return nil, nil
 		})
 		require.Error(t, err)
+
+		t.Run("with explicit name", func(t *testing.T) {
+			err := testWorker.RegisterWorkflow(func(ctx *WorkflowContext) (any, error) {
+				return nil, nil
+			}, RegisterWithName("MyWorkflow2"))
+			require.NoError(t, err)
+		})
 	})
 	t.Run("register activity", func(t *testing.T) {
 		err := testWorker.RegisterActivity(testActivity)
 		require.NoError(t, err)
+
+		t.Run("with explicit name", func(t *testing.T) {
+			err := testWorker.RegisterActivity(testActivity, RegisterWithName("MyActivity"))
+			require.NoError(t, err)
+		})
 	})
 	t.Run("register activity - anonymous func", func(t *testing.T) {
 		err := testWorker.RegisterActivity(func(ctx ActivityContext) (any, error) {
 			return nil, nil
 		})
 		require.Error(t, err)
+
+		t.Run("with explicit name", func(t *testing.T) {
+			err := testWorker.RegisterActivity(func(ctx ActivityContext) (any, error) {
+				return nil, nil
+			}, RegisterWithName("MyActivity2"))
+			require.NoError(t, err)
+		})
 	})
 }
 
@@ -69,6 +93,16 @@ func TestWorkerOptions(t *testing.T) {
 	})
 }
 
+func TestRegisterOptions(t *testing.T) {
+	t.Run("with name", func(t *testing.T) {
+		defaultOpts := registerOptions{}
+		options, err := processRegisterOptions(defaultOpts, RegisterWithName("testWorkflow"))
+		require.NoError(t, err)
+		assert.NotEmpty(t, options.Name)
+		assert.Equal(t, "testWorkflow", options.Name)
+	})
+}
+
 func returnWorkerOptions(opts ...workerOption) workerOptions {
 	options := new(workerOptions)
 	for _, configure := range opts {
@@ -104,6 +138,12 @@ func TestGetFunctionName(t *testing.T) {
 		require.Error(t, err)
 		assert.Equal(t, "", name)
 	})
+
+	t.Run("get function name - anonymous", func(t *testing.T) {
+		name, err := getFunctionName(func() {})
+		require.Error(t, err)
+		assert.Equal(t, "", name)
+	})
 }
 
 func testWorkflow(ctx *WorkflowContext) (any, error) {