Conversation
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 54.62% 54.62%
=======================================
Files 51 51
Lines 3469 3469
=======================================
Hits 1895 1895
Misses 1434 1434
Partials 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Albert Callarisa <albert@diagrid.io>
| backport: | ||
| uses: dapr/.github/.github/workflows/backport.yaml@main | ||
| secrets: | ||
| dapr_bot_token: ${{ secrets.DAPR_BOT_TOKEN }} |
There was a problem hiding this comment.
Just a thought, do we need to be using the DAPR_BOT_TOKEN for this or can we use the standard actions workflow secret?
There was a problem hiding this comment.
it needs to be the dapr_bot due to a security measure in github where PRs created from workflows don't trigger other actions, meaning the backport PR wouldn't have CI checks.
mikeee
left a comment
There was a problem hiding this comment.
I'm fine with the bot token for now but workflows should probably be using the finegrained repo token later
Brings https://github.com/dapr/dapr/blob/master/.github/workflows/backport.yaml