Skip to content

Fix validations using the latest CLI#814

Merged
JoshVanL merged 8 commits intodapr:mainfrom
acroca:fix-validations
Mar 5, 2026
Merged

Fix validations using the latest CLI#814
JoshVanL merged 8 commits intodapr:mainfrom
acroca:fix-validations

Conversation

@acroca
Copy link
Copy Markdown
Member

@acroca acroca commented Mar 2, 2026

Remove == APP == from validation assertions, as it's been removed from the CLI (PR)

…rom the CLI

Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca requested review from a team as code owners March 2, 2026 14:37
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.64%. Comparing base (24c79ec) to head (99160e2).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   54.64%   54.64%           
=======================================
  Files          51       51           
  Lines        3466     3466           
=======================================
  Hits         1894     1894           
  Misses       1433     1433           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca marked this pull request as draft March 3, 2026 14:30
acroca added 4 commits March 4, 2026 11:40
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca closed this Mar 5, 2026
@acroca acroca reopened this Mar 5, 2026
@acroca acroca closed this Mar 5, 2026
@acroca acroca reopened this Mar 5, 2026
@acroca acroca closed this Mar 5, 2026
@acroca acroca reopened this Mar 5, 2026
@acroca acroca marked this pull request as ready for review March 5, 2026 10:23
@acroca
Copy link
Copy Markdown
Member Author

acroca commented Mar 5, 2026

Reopened multiple times to run CI. So far it's been green in all triggers

JoshVanL
JoshVanL previously approved these changes Mar 5, 2026
mikeee
mikeee previously approved these changes Mar 5, 2026
Copy link
Copy Markdown
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, feel free to ping me for reruns in the future

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates all example applications and their README validation files to be compatible with the latest Dapr CLI, which removed the == APP == prefix from application stdout output (see dapr/cli#1595). The changes ensure that example validations continue to pass by removing the prefix from assertions, switching logging from stderr to stdout, and improving test reliability with retry mechanisms.

Changes:

  • Replaced all log.* calls with a custom logger = log.New(os.Stdout, "", log.LstdFlags) in example Go files to ensure output goes to stdout instead of stderr.
  • Removed == APP == prefix from all expected_stdout_lines and Result sections in README markdown files.
  • Improved test reliability by adding retry logic to client examples (service, grpc-service, pubsub) and wrapping cleanup commands in proper <!-- STEP --> blocks.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
examples/workflow/main.go Switch log.* to logger.* (stdout)
examples/workflow/README.md Remove == APP == from assertions and results
examples/workflow-taskexecutionid/main.go Switch log.* to logger.* (stdout)
examples/workflow-taskexecutionid/README.md Remove == APP == from assertions and results
examples/workflow-parallel/main.go Switch log.* to logger.* (stdout)
examples/workflow-parallel/README.md Remove == APP == from assertions and results
examples/streamsub/sub/sub.go Switch log.* to logger.* (stdout)
examples/streamsub/pub/pub.go Switch log.* to logger.* (stdout)
examples/streamsub/README.md Remove == APP == from result output
examples/service/serving/http/main.go Switch log.* to logger.* (stdout)
examples/service/serving/grpc/main.go Switch log.* to logger.* (stdout)
examples/service/client/main.go Add retry loop for service invocation
examples/service/README.md Remove == APP ==, remove background/sleep, add cleanup step
examples/pubsub/sub/sub.go Switch log.* to logger.* (stdout)
examples/pubsub/pub/pub.go Add TCP wait loop for subscriber readiness
examples/pubsub/README.md Remove == APP ==, remove background/sleep, add cleanup step
examples/jobs/main.go Switch log.* to logger.* (stdout)
examples/hello-world/README.md Remove == APP == from assertions
examples/grpc-service/server/main.go Switch log.* to logger.* (stdout)
examples/grpc-service/client/main.go Switch log.* to logger.*, add retry loop
examples/grpc-service/README.md Remove == APP ==, remove background/sleep, add cleanup step
examples/crypto/main.go Switch log.* to logger.* (stdout)
examples/crypto/README.md Remove == APP == from assertions and results
examples/conversation-alpha2/main.go Switch log.* to logger.* (stdout)
examples/conversation-alpha2/README.md Remove == APP == from assertions and results
examples/conversation-alpha1/main.go Switch log.* to logger.* (stdout)
examples/conversation-alpha1/README.md Remove == APP == from assertions and results
examples/configuration/README.md Remove == APP == from assertions, trailing whitespace cleanup
examples/actor/serving/main.go Switch log.* to logger.* (stdout)
examples/actor/README.md Remove == APP ==, remove background/sleep, add cleanup step
examples/socket/README.md Remove == APP == from assertions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca dismissed stale reviews from mikeee and JoshVanL via 0043e05 March 5, 2026 10:39
@acroca acroca requested a review from Copilot March 5, 2026 10:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JoshVanL JoshVanL merged commit ff4e5eb into dapr:main Mar 5, 2026
25 of 26 checks passed
@acroca acroca deleted the fix-validations branch March 5, 2026 13:21
JoshVanL added a commit to JoshVanL/go-sdk that referenced this pull request Mar 17, 2026
Fix validations using the latest CLI

Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL added a commit that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants