chore: Fix bug, return type is required

Signed-off-by: Javier Aliaga <[email protected]>

Author: javier-aliaga

durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestrationContext.java

@@ -411,7 +411,7 @@ default Task<Void> callSubOrchestrator(String name) {
    * @return a new {@link Task} that completes when the sub-orchestration completes or fails
    */
   default Task<Void> callSubOrchestrator(String name, Object input) {
-    return this.callSubOrchestrator(name, input, null);
+    return this.callSubOrchestrator(name, input, Void.class);
   }
 
   /**

durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java

@@ -103,7 +103,7 @@ public TaskOrchestratorResult execute(List<OrchestratorService.HistoryEvent> pas
     } catch (Exception e) {
       // The orchestrator threw an unhandled exception - fail it
       // TODO: What's the right way to log this?
-      logger.warning("The orchestrator failed with an unhandled exception: " + e.toString());
+      logger.warning("The orchestrator failed with an unhandled exception: " + e);
       context.fail(new FailureDetails(e));
     }
 

sdk-workflows/src/main/java/io/dapr/workflows/WorkflowContext.java

@@ -20,7 +20,6 @@
 import org.slf4j.Logger;
 
 import javax.annotation.Nullable;
-
 import java.time.Duration;
 import java.time.Instant;
 import java.time.ZonedDateTime;
@@ -383,7 +382,7 @@ default Task<Void> callChildWorkflow(String name) {
    * @return a new {@link Task} that completes when the child-workflow completes or fails
    */
   default Task<Void> callChildWorkflow(String name, Object input) {
-    return this.callChildWorkflow(name, input, null);
+    return this.callChildWorkflow(name, input, Void.class);
   }
 
   /**

sdk-workflows/src/test/java/io/dapr/workflows/DefaultWorkflowContextTest.java

@@ -38,7 +38,11 @@
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.eq;
-import static org.mockito.Mockito.*;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
 
 public class DefaultWorkflowContextTest {
   private DefaultWorkflowContext context;
@@ -284,7 +288,7 @@ public void callChildWorkflowWithName() {
     String expectedName = "TestActivity";
 
     context.callChildWorkflow(expectedName);
-    verify(mockInnerContext, times(1)).callSubOrchestrator(expectedName, null, null, null, null);
+    verify(mockInnerContext, times(1)).callSubOrchestrator(expectedName, null, null, null, Void.class);
   }
 
   @Test

sdk-workflows/src/test/java/io/dapr/workflows/runtime/DefaultWorkflowActivityContextTest.java

@@ -5,7 +5,9 @@
 import org.junit.jupiter.api.Test;
 import org.slf4j.Logger;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
@@ -21,6 +23,7 @@ void shouldSuccessfullyCreateContextAndReturnCorrectValuesForAllMethods() {
     when(mockInnerContext.getName()).thenReturn("TestActivity");
     when(mockInnerContext.getInput(any())).thenReturn("TestInput");
     when(mockInnerContext.getTaskExecutionId()).thenReturn("TestExecutionId");
+    when(mockInnerContext.getTraceParent()).thenReturn("00244654132154564654");
 
     assertNotNull(context.getLogger());
     assertEquals("TestActivity", context.getName());
@@ -29,6 +32,7 @@ void shouldSuccessfullyCreateContextAndReturnCorrectValuesForAllMethods() {
 
     assertEquals("TestInput", input);
     assertEquals("TestExecutionId", context.getTaskExecutionId());
+    assertEquals("00244654132154564654", context.getTraceParent());
   }
 
   @Test