Skip to content

Conversation

@artursouza
Copy link
Contributor

@artursouza artursouza commented Oct 23, 2024

Description

Implements tracing for actors. It has never been done before.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1151

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Souza <[email protected]>
@artursouza
Copy link
Contributor Author

This is just a test scenario, not yet the fix.

@artursouza artursouza changed the title Implements tracing for actors Validate tracing for actors Nov 13, 2024
Comment on lines +50 to +64
try (DaprClient client = run.newDaprClientBuilder().build()) {
MyActor myActor =
new ActorProxyBuilder<>(
"MyActorTest",
MyActor.class,
clientRun.newActorClient()).build(new ActorId("123456"));
try (Scope scope = span.makeCurrent()) {
client.waitForSidecar(10000).block();
myActor.say("hello world")
.contextWrite(getReactorContext(openTelemetry))
.block();
}
} finally {
span.end();
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example showing how the client app should invoke actors and tracing headers to work.

@artursouza artursouza closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't propagate trace headers with actors

1 participant