Add unit test

Signed-off-by: Shubham Sharma <[email protected]>

Author: shubham1172

package.json

@@ -13,9 +13,10 @@
         "test:e2e:http": "TEST_SECRET_1=secret_val_1 TEST_SECRET_2=secret_val_2 dapr run --app-id test-suite --app-protocol http --app-port 50001 --dapr-http-port 50000 --components-path ./test/components -- jest --runInBand --detectOpenHandles --testMatch [ '**/test/e2e/http/(client|server).test.ts' ]",
         "test:e2e:http:actors": "TEST_SECRET_1=secret_val_1 TEST_SECRET_2=secret_val_2 dapr run --app-id test-suite --app-protocol http --app-port 50001 --dapr-http-port 50000 --components-path ./test/components -- jest --runInBand --detectOpenHandles --testMatch [ '**/test/e2e/http/actors.test.ts' ]",
         "test:unit": "jest --runInBand --detectOpenHandles",
-        "test:unit:all": "npm run test:unit:main && npm run test:unit:actors && npm run test:unit:utils",
+        "test:unit:all": "npm run test:unit:main && npm run test:unit:actors && npm run test:unit:logger && npm run test:unit:utils",
         "test:unit:main": "NODE_ENV=test npm run test:unit 'test/unit/main/.*\\.test\\.ts'",
         "test:unit:actors": "NODE_ENV=test npm run test:unit 'test/unit/actor/.*\\.test\\.ts'",
+        "test:unit:logger": "NODE_ENV=test npm run test:unit 'test/unit/logger/.*\\.test\\.ts'",
         "test:unit:utils": "NODE_ENV=test npm run test:unit 'test/unit/utils/.*\\.test\\.ts'",
         "lint": "eslint . --ext .js,.jsx,.ts,.tsx",
         "build": "./scripts/build.sh",

src/logger/Logger.ts

@@ -28,13 +28,13 @@ export class Logger {
      * @param options Logger options
      */
     constructor(options?: LoggerOptions) {
-        if (options && options.logLevel) {
+        if (options !== undefined && options.logLevel !== undefined) {
             this.logLevel = options.logLevel;
         } else {
             this.logLevel = LogLevel.info;
         }
 
-        if (options && options.logService) {
+        if (options !== undefined && options.logService !== undefined) {
             this.logService = options.logService;
         } else {
             this.logService = new ConsoleLoggerService();

test/unit/logger/logger.test.ts

@@ -0,0 +1,70 @@
+/*
+Copyright 2022 The Dapr Authors
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+    http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+import { LoggerService } from "../../../src";
+import { Logger } from "../../../src/logger/Logger"
+import { LogLevel } from "../../../src/types/logger/LogLevel"
+
+describe('Logger', () => {
+    it('should not display logs below the set log level', () => {
+        // arrange
+        const mockLoggerService = new MockLoggerService();
+        const errorLogger = new Logger({ logLevel: LogLevel.error, logService: mockLoggerService })
+        const infoLogger = new Logger({ logLevel: LogLevel.info, logService: mockLoggerService })
+        const debugLogger = new Logger({ logLevel: LogLevel.debug, logService: mockLoggerService })
+
+        // act
+        callAllLogLevels(errorLogger)
+        callAllLogLevels(infoLogger)
+        callAllLogLevels(debugLogger)
+
+        // assert
+        expect(mockLoggerService.errorCounter).toBe(1+1+1)
+        expect(mockLoggerService.warnCounter).toBe(0+1+1)
+        expect(mockLoggerService.infoCounter).toBe(0+1+1)
+        expect(mockLoggerService.verboseCounter).toBe(0+0+1)
+        expect(mockLoggerService.debugCounter).toBe(0+0+1)
+    })
+})
+
+class MockLoggerService implements LoggerService {
+    public errorCounter = 0;
+    public warnCounter = 0;
+    public infoCounter = 0;
+    public verboseCounter = 0;
+    public debugCounter = 0;
+
+    error(_message: any, ..._optionalParams: any[]): void {
+        this.errorCounter++;
+    }
+    warn(_message: any, ..._optionalParams: any[]): void {
+        this.warnCounter++;
+    }
+    info(_message: any, ..._optionalParams: any[]): void {
+        this.infoCounter++;
+    }
+    verbose(_message: any, ..._optionalParams: any[]): void {
+        this.verboseCounter++;
+    }
+    debug(_message: any, ..._optionalParams: any[]): void {
+        this.debugCounter++
+    }
+}
+
+function callAllLogLevels(logger: Logger) {
+    logger.error("component", "area", "message")
+    logger.warn("component", "area", "message")
+    logger.info("component", "area", "message")
+    logger.verbose("component", "area", "message")
+    logger.debug("component", "area", "message")
+}