Skip to content

Commit 16dd3c2

Browse files
Update to the publish step
Signed-off-by: Xavier Geerinck <[email protected]>
1 parent 28d32ce commit 16dd3c2

File tree

1 file changed

+25
-2
lines changed

1 file changed

+25
-2
lines changed

.github/workflows/build.yml

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ on:
1717
branches:
1818
- master
1919
- release-*
20+
- issue_223
2021
tags:
2122
- v*
2223
pull_request:
@@ -40,11 +41,12 @@ jobs:
4041
registry-url: 'https://registry.npmjs.org'
4142

4243
# - name: Configure to publish to @dapr/dapr
43-
# run: sed -i s#@dapr/dapr"#"@dapr/dapr"# package.json
44+
# run: sed -i s#"dapr-client"#"@dapr/dapr"# package.json
4445

4546
- name: Build Package
4647
run: ./scripts/build.sh
4748

49+
# @TODO: add a depend on the test-e2e pipeline?
4850
# - name: Run unit tests
4951
# id: tests
5052
# run: npm run test:unit:all
@@ -55,9 +57,30 @@ jobs:
5557
# - name: Is Release?
5658
# if: startswith(github.ref, 'refs/tags/v')
5759
# run: echo "DEPLOY_PACKAGE=true" >> $GITHUB_ENV
60+
61+
# run: npm set //registry.npmjs.org/:_authToken $NODE_AUTH_TOKEN
62+
63+
# - name: Authorize us to @dapr/dapr
64+
# run: |
65+
# npm set //registry.npmjs.org/:_authToken ${{ secrets.NPM_TOKEN_NEW }}
66+
67+
# - name: Show NPM Config
68+
# run: cat ~/.npmrc
69+
70+
# - name: Show NPM Config
71+
# run: npm whoami
72+
5873

74+
# - name: Publish to npm (dapr-client)
75+
# if: env.DEPLOY_PACKAGE == 'true'
76+
# run: npm run build && npm pack && npm publish build/ --access public
77+
# env:
78+
# NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
79+
80+
# Publish to @dapr/dapr
81+
# note: package.json gets updated here for the new package name
5982
- name: Publish to npm (@dapr/dapr)
6083
# if: env.DEPLOY_PACKAGE == 'true'
61-
run: npm publish build/ --access public
84+
run: npm publish --access public
6285
env:
6386
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

0 commit comments

Comments
 (0)