Refactor based on review comments

Signed-off-by: Shubham Sharma <[email protected]>

Author: shubham1172

src/implementation/Client/DaprClient.ts

@@ -53,14 +53,14 @@ export default class DaprClient {
   readonly actor: IClientActorBuilder;
 
   constructor(
-    daprHost = Settings.getDefaultHost()
+    daprHost?: string
     , daprPort?: string
     , communicationProtocol: CommunicationProtocolEnum = CommunicationProtocolEnum.HTTP
     , options: DaprClientOptions = {
       isKeepAlive: true
     }
   ) {
-    this.daprHost = daprHost;
+    this.daprHost = daprHost ?? Settings.getDefaultHost();
     this.daprPort = daprPort ?? Settings.getDefaultPort(communicationProtocol);
     this.communicationProtocol = communicationProtocol;
     this.options = options;

src/implementation/Client/GRPCClient/GRPCClient.ts

@@ -20,8 +20,8 @@ export default class GRPCClient implements IClient {
       isKeepAlive: true
     }
   ) {
-    this.clientHost = host ?? Settings.getDefaultHost();
-    this.clientPort = port ?? Settings.getDefaultGrpcPort();
+    this.clientHost = host;
+    this.clientPort = port;
     this.clientCredentials = ChannelCredentials.createInsecure();
     this.options = options;
 

src/implementation/Client/HTTPClient/HTTPClient.ts

@@ -24,7 +24,7 @@ export default class HTTPClient implements IClient {
     }
   ) {
     this.clientHost = host;
-    this.clientPort = port ?? port;
+    this.clientPort = port;
     this.options = options;
 
     if (!this.clientHost.startsWith('http://') && !this.clientHost.startsWith('https://')) {

src/implementation/Server/DaprServer.ts

@@ -36,18 +36,18 @@ export default class DaprServer {
   readonly client: DaprClient;
 
   constructor(
-    serverHost = Settings.getDefaultHost()
+    serverHost?: string
     , serverPort?: string
-    , daprHost = Settings.getDefaultHost()
+    , daprHost?: string
     , daprPort?: string
     , communicationProtocol: CommunicationProtocolEnum = CommunicationProtocolEnum.HTTP
     , clientOptions: DaprClientOptions = {
       isKeepAlive: true
     }
   ) {
-    this.serverHost = serverHost;
+    this.serverHost = serverHost ?? Settings.getDefaultHost();
     this.serverPort = serverPort ?? Settings.getDefaultAppPort(communicationProtocol);
-    this.daprHost = daprHost;
+    this.daprHost = daprHost ?? Settings.getDefaultHost();
     this.daprPort = daprPort ?? Settings.getDefaultPort(communicationProtocol);
 
     // Create a client to interface with the sidecar from the server side