feat(): Update method signature for http client invoker to use optional parameter (#299)

shubham1172 · web-flow · commit 5780786e89df · 2022-06-14T07:39:42.000+02:00
(tiny fix) update method signature for http client invoker

Signed-off-by: Shubham Sharma &lt;shubhash@microsoft.com&gt;
diff --git a/src/implementation/Client/HTTPClient/invoker.ts b/src/implementation/Client/HTTPClient/invoker.ts
@@ -23,7 +23,7 @@ export default class HTTPClientInvoker implements IClientInvoker {
     this.client = client;
   }
 
-  async invoke(appId: string, methodName: string, method: HttpMethod = HttpMethod.GET, data: object = {}): Promise<object> {
+  async invoke(appId: string, methodName: string, method: HttpMethod = HttpMethod.GET, data?: object): Promise<object> {
     const fetchOptions = {
       method
     };
@@ -35,7 +35,7 @@ export default class HTTPClientInvoker implements IClientInvoker {
       };
     }
 
-    if (method !== HttpMethod.GET && data !== {}) {
+    if (method !== HttpMethod.GET && data !== undefined) {
       // @ts-ignore
       fetchOptions.body = JSON.stringify(data);
     }

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export default class HTTPClientInvoker implements IClientInvoker {`
`23`	`23`	`this.client = client;`
`24`	`24`	`}`
`25`	`25`
`26`		`- async invoke(appId: string, methodName: string, method: HttpMethod = HttpMethod.GET, data: object = {}): Promise<object> {`
	`26`	`+ async invoke(appId: string, methodName: string, method: HttpMethod = HttpMethod.GET, data?: object): Promise<object> {`
`27`	`27`	`const fetchOptions = {`
`28`	`28`	`method`
`29`	`29`	`};`
`@@ -35,7 +35,7 @@ export default class HTTPClientInvoker implements IClientInvoker {`
`35`	`35`	`};`
`36`	`36`	`}`
`37`	`37`
`38`		`- if (method !== HttpMethod.GET && data !== {}) {`
	`38`	`+ if (method !== HttpMethod.GET && data !== undefined) {`
`39`	`39`	`// @ts-ignore`
`40`	`40`	`fetchOptions.body = JSON.stringify(data);`
`41`	`41`	`}`