Skip to content

Commit 75984fe

Browse files
Remove DaprClient reference in ActorClient, not needed since we build it again anyways
Signed-off-by: Xavier Geerinck <[email protected]>
1 parent 1e4a7af commit 75984fe

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

src/actors/client/ActorClient/ActorClient.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,29 @@ import ActorClientGRPC from './ActorClientGRPC';
77
import ActorClientHTTP from './ActorClientHTTP';
88

99
export default class ActorClient {
10-
readonly daprClient: DaprClient;
10+
readonly daprHost: string;
11+
readonly daprPort: string;
12+
readonly communicationProtocol: CommunicationProtocolEnum;
1113
readonly actor: IClientActor;
1214

13-
constructor(daprClient: DaprClient) {
14-
this.daprClient = daprClient;
15+
constructor(daprHost: string, daprPort: string, communicationProtocol: CommunicationProtocolEnum) {
16+
this.daprHost = daprHost;
17+
this.daprPort = daprPort;
18+
this.communicationProtocol = communicationProtocol;
1519

1620
// Builder
17-
switch (daprClient.communicationProtocol) {
21+
switch (communicationProtocol) {
1822
case CommunicationProtocolEnum.GRPC: {
19-
const client = new GRPCClient(this.daprClient.daprHost, this.daprClient.daprPort);
23+
const client = new GRPCClient(this.daprHost, this.daprPort);
2024
this.actor = new ActorClientGRPC(client);
2125
break;
2226
}
2327
case CommunicationProtocolEnum.HTTP:
2428
default: {
25-
const client = new HTTPClient(this.daprClient.daprHost, this.daprClient.daprPort);
29+
const client = new HTTPClient(this.daprHost, this.daprPort);
2630
this.actor = new ActorClientHTTP(client);
2731
break;
2832
}
2933
}
3034
}
31-
32-
getDaprClient(): DaprClient {
33-
return this.daprClient;
34-
}
3535
}

src/actors/client/ActorProxyBuilder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default class ActorProxyBuilder<T> {
1111
constructor(actorTypeClass: Class<T>, daprClient: DaprClient) {
1212
this.actorTypeClass = actorTypeClass;
1313
this.daprClient = daprClient;
14-
this.actorClient = new ActorClient(daprClient);
14+
this.actorClient = new ActorClient(daprClient.getDaprHost(), daprClient.getDaprPort(), daprClient.getCommunicationProtocol());
1515
}
1616

1717
build(actorId: ActorId): T {

src/actors/runtime/AbstractActor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default abstract class AbstractActor {
3838
*/
3939
constructor(daprClient: DaprClient, id: ActorId) {
4040
this.daprClient = daprClient;
41-
this.actorClient = new ActorClient(daprClient);
41+
this.actorClient = new ActorClient(daprClient.getDaprHost(), daprClient.getDaprPort(), daprClient.getCommunicationProtocol());
4242

4343
this.id = id;
4444

src/implementation/Client/DaprClient.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,4 +91,8 @@ export default class DaprClient {
9191
getDaprPort(): string {
9292
return this.daprPort;
9393
}
94+
95+
getCommunicationProtocol(): CommunicationProtocolEnum {
96+
return this.communicationProtocol;
97+
}
9498
}

0 commit comments

Comments
 (0)