feat: Add Configuration API test for subscribe all keys (#327)

* Add test for subscribe

Signed-off-by: Shubham Sharma <[email protected]>

* Use done() cb

Signed-off-by: Shubham Sharma <[email protected]>

* Fix test

Signed-off-by: Shubham Sharma <[email protected]>

* Close the stream

Signed-off-by: Shubham Sharma <[email protected]>

Author: shubham1172

scripts/test-e2e.sh

@@ -11,7 +11,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-./test-init.sh
+./scripts/test-init.sh
 
 # Start gRPC tests
 echo "Running gRPC tests"

scripts/test-init.sh

@@ -11,9 +11,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-echo "Starting Docker"
-sudo service docker start
-sleep 3
+if (! docker stats --no-stream ); then
+    echo "Docker is not running, please start it first"
+    exit 1
+fi
 
 # Start MQTT for Binding tests
 # Dashboard: http://localhost:18083 (user: admin, pass: public)

test/e2e/grpc/client.test.ts

@@ -367,31 +367,32 @@ describe('grpc/client', () => {
       // expect(conf.items.filter(i => i.key == "myconfigkey1")[0].metadata).toHaveProperty("hello");
     });
 
-    // // @todo: figure out, subscribe doesn't pass keys but doesn't listen to anything?
-    // // https://github.com/dapr/dapr/issues/4529
-    // it('should be able to subscribe to configuration item changes on all keys', async () => {
-    //   const m = jest.fn(async (res: SubscribeConfigurationResponse) => { });
+    it('should be able to subscribe to configuration item changes on all keys', async () => {
+      const m = jest.fn(async (_res: SubscribeConfigurationResponse) => { return; });
+
+      const stream = await client.configuration.subscribe("config-redis", m);
 
-    //   console.log("Creating Subscription");
-    //   await client.configuration.subscribe("config-redis", m);
+      // Update the configuration item
+      await DockerUtils.executeDockerCommand("dapr_redis redis-cli MSET myconfigkey3 mynewvalue||2");
 
-    //   // Change an item
-    //   await DockerUtils.executeDockerCommand("dapr_redis redis-cli MSET myconfigkey3 mynewvalue||1");
+      expect(m.mock.calls[0][0].items.length).toEqual(1);
+      expect(m.mock.calls[0][0].items[0].key).toEqual("myconfigkey3");
+      expect(m.mock.calls[0][0].items[0].value).toEqual("mynewvalue");
 
-    //   expect(m.mock.calls.length).toEqual(1);
-    // });
+      stream.stop();
+    });
 
     it('should be able to subscribe to configuration item changes on specific keys', async () => {
       const m = jest.fn(async (_res: SubscribeConfigurationResponse) => { return; });
 
-      const stream1 = await client.configuration.subscribeWithKeys("config-redis", ["myconfigkey1", "myconfigkey2"], m);
+      const stream = await client.configuration.subscribeWithKeys("config-redis", ["myconfigkey1", "myconfigkey2"], m);
       await DockerUtils.executeDockerCommand("dapr_redis redis-cli MSET myconfigkey1 key1_mynewvalue||1");
 
       expect(m.mock.calls.length).toEqual(1);
       expect(m.mock.calls[0][0].items[0].key).toEqual("myconfigkey1");
       expect(m.mock.calls[0][0].items[0].value).toEqual("key1_mynewvalue");
 
-      await stream1.stop();
+      await stream.stop();
     });
 
     it('should be able to subscribe with metadata', async () => {
@@ -410,14 +411,14 @@ describe('grpc/client', () => {
     it('should be able to unsubscribe', async () => {
       const m = jest.fn(async (_res: SubscribeConfigurationResponse) => { return; });
 
-      const stream1 = await client.configuration.subscribeWithMetadata("config-redis", ["myconfigkey1", "myconfigkey2"], { "hello": "world" }, m);
+      const stream = await client.configuration.subscribeWithMetadata("config-redis", ["myconfigkey1", "myconfigkey2"], { "hello": "world" }, m);
       await DockerUtils.executeDockerCommand("dapr_redis redis-cli MSET myconfigkey1 key1_mynewvalue||1");
 
       expect(m.mock.calls.length).toEqual(1);
       expect(m.mock.calls[0][0].items[0].key).toEqual("myconfigkey1");
       expect(m.mock.calls[0][0].items[0].value).toEqual("key1_mynewvalue");
 
-      await stream1.stop();
+      stream.stop();
 
       await DockerUtils.executeDockerCommand("dapr_redis redis-cli MSET myconfigkey1 key1_mynewvalue2||1");
 
@@ -444,8 +445,8 @@ describe('grpc/client', () => {
       expect(m2.mock.calls[0][0].items[0].key).toEqual("myconfigkey1");
       expect(m2.mock.calls[0][0].items[0].value).toEqual("key1_mynewvalue");
 
-      await stream1.stop();
-      await stream2.stop();
+      stream1.stop();
+      stream2.stop();
     });
   });
 });