Skip to content

Commit 252b7c3

Browse files
feat: merge path matching ingress/egress paths (#60)
Signed-off-by: nelson.parente <[email protected]>
1 parent bfcbc5b commit 252b7c3

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

20240517-R-http-metrics-path-matching.md

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,10 @@ spec:
4242
http:
4343
increasedCardinality: true
4444
pathMatching:
45-
ingress:
4645
- /orders/{orderID}/items/{itemID}
4746
- /users/{userID}
4847
- /categories/{categoryID}/subcategories/{subCategoryID}
4948
- /customers/{customerID}/orders/{orderID}
50-
egress:
51-
- /orders
52-
- /orders/{orderID}/items/{itemID}
53-
- /categories
54-
- /users
5549
```
5650
5751
##### Examples
@@ -75,15 +69,12 @@ dapr_http_server_request_count{app_id="ping",method="InvokeService/ping",status=
7569
http:
7670
increasedCardinality: false
7771
pathMatching:
78-
ingress:
79-
- /orders/{orderID}
80-
egress:
8172
- /orders/{orderID}
8273
```
8374

8475
```
8576
dapr_http_server_request_count{app_id="ping",method="GET",path="/orders/{orderID}",status="200"} 4
86-
dapr_http_server_request_count{app_id="ping",method="GET",path="_",status="200"} 1
77+
dapr_http_server_request_count{app_id="ping",method="GET",path="",status="200"} 1
8778
```
8879

8980
- High Cardinality Without Path Matching
@@ -107,9 +98,6 @@ dapr_http_server_request_count{app_id="ping",method="GET",path="/orders/1234567"
10798
http:
10899
increasedCardinality: true
109100
pathMatching:
110-
ingress:
111-
- /orders/{orderID}
112-
egress:
113101
- /orders/{orderID}
114102
```
115103
@@ -119,7 +107,7 @@ dapr_http_server_request_count{app_id="ping",method="GET",path="/orders/{orderID
119107
```
120108
#### Features
121109

122-
- `pathMatching.ingress/pathMatching.egress` users can specify paths for ingress and egress path matching.
110+
- `pathMatching` where users can specify paths for path matching.
123111

124112
The path matching will use the same patterns as the Go standard library (see https://pkg.go.dev/net/http#hdr-Patterns), ensuring reliable and well-supported path matching.
125113

0 commit comments

Comments
 (0)