-
Notifications
You must be signed in to change notification settings - Fork 138
Implement multi-app workflows #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e5e28e to
f1e653d
Compare
Signed-off-by: Albert Callarisa <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #844 +/- ##
===============================================
Coverage ? 87.17%
===============================================
Files ? 93
Lines ? 6159
Branches ? 0
===============================================
Hits ? 5369
Misses ? 790
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Albert Callarisa <[email protected]>
elena-kolevska
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you also pls add an example for non-green paths?
I've added a couple of examples showing how it handles errors coming from both workflow and activities. |
Signed-off-by: Albert Callarisa <[email protected]>
Signed-off-by: Albert Callarisa <[email protected]>
* 1.16.0-rc1 Signed-off-by: Elena Kolevska <[email protected]> * [Conversation API - Alpha2] Add new tool calling capability (#822) (#832) * initial * fixes after proto change upstream * minor name changes and cleanup unused function * refactors, updates to readme, linting * feedback * feedback, updates * fix import in examples * cleanup, import, lint, more conversation helpers * clarify README, minor test import changes, copyright * feedback DRY test_conversation file * lint * move conversation classes in _response module to conversation module. Some example README refactor/lint * minor readme change * Update daprdocs/content/en/python-sdk-docs/python-client.md * lint * updates to fix issue with tool calling helper when dealing with classes instead of dataclasses, and also with serializatin output of the tool back to the LLM * coalesce conv helper tests, fix typing lint * make indent line method doc more dev friendly * tackle some feedback, still missing unit tests * add unit test to convert_value_to_struct * more unit tests per feedback * make async version of unit test conversation * add some information how to run markdown tests with a different runtime * ran tox -e ruff, even though tox -e flake8 was fine * add tests to increase coverage in conversation and conversation_helpers that codecov pointed out * add more information on execute registered tools, also added more tests for them to validate * fix test failing on py 1.13. Merge two unit test files per feedback * Linter * fix typing issue with UnionType in py3.9 --------- Signed-off-by: Filinto Duran <[email protected]> Signed-off-by: Elena Kolevska <[email protected]> Co-authored-by: Albert Callarisa <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> * update docs with tool calling helpers info (#838) Signed-off-by: Filinto Duran <[email protected]> * 1.16.0rc2 Signed-off-by: Elena Kolevska <[email protected]> * use latest durabletask (#840) Signed-off-by: Cassandra Coyle <[email protected]> * 1.16.0 Signed-off-by: Elena Kolevska <[email protected]> * Adds support for interceptors and concurrency_options arguments in the workflow engine (#841) Signed-off-by: Albert Callarisa <[email protected]> * Implement multi-app workflows (#844) * feat: Adds support for cross-app calls. Signed-off-by: Albert Callarisa <[email protected]> * Use durabletask alpha.9 Signed-off-by: Albert Callarisa <[email protected]> * Added examples for error scenarios in multi-app workflow Signed-off-by: Albert Callarisa <[email protected]> * Remove unnecessary hardcoded ports Signed-off-by: Albert Callarisa <[email protected]> --------- Signed-off-by: Albert Callarisa <[email protected]> * chore: Rename wait_until_ready to wait_for_sidecar (#843) Signed-off-by: Albert Callarisa <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> * 1.16.1rc1 (#846) Signed-off-by: Albert Callarisa <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Filinto Duran <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Albert Callarisa <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Filinto Duran <[email protected]> Co-authored-by: Albert Callarisa <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Albert Callarisa <[email protected]>
Adds support for multi-app workflow invocations, both child workflows and activities, just providing
app_idin the callThe multi-app documentation is here: https://docs.dapr.io/developing-applications/building-blocks/workflow/workflow-multi-app/, and at the moment is fully supported in the Go SDK, and partially supported in the Java SDK.
This PR will make the multi-app functionality fully supported in the python SDK.