-
Notifications
You must be signed in to change notification settings - Fork 138
Add new tool calling capability #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
fdff6cf
initial
filintod bbf381c
fixes after proto change upstream
filintod dbf6f56
minor name changes and cleanup unused function
filintod 7a9a6cf
refactors, updates to readme, linting
filintod e412740
Merge branch 'main' into filinto/tool-calling
filintod 08fdcab
Merge branch 'main' into filinto/tool-calling
filintod 287d4b7
feedback
filintod b548c00
feedback, updates
filintod 975df5d
fix import in examples
filintod 6bbb0f5
cleanup, import, lint, more conversation helpers
filintod 8697b8e
clarify README, minor test import changes, copyright
filintod 5d16fb5
feedback DRY test_conversation file
filintod d0703ae
lint
filintod e10d2d8
move conversation classes in _response module to conversation module.
filintod 3854bbd
minor readme change
filintod 2018978
Update daprdocs/content/en/python-sdk-docs/python-client.md
filintod ee6729e
lint
filintod 7126b2f
updates to fix issue with tool calling helper when dealing with class…
filintod fbc0195
coalesce conv helper tests, fix typing lint
filintod 0d275e4
make indent line method doc more dev friendly
filintod a41a413
tackle some feedback, still missing unit tests
filintod 5db8a56
add unit test to convert_value_to_struct
filintod 6e3d2ba
more unit tests per feedback
filintod a4870a9
make async version of unit test conversation
filintod 5bec64e
add some information how to run markdown tests with a different runtime
filintod 4bf4aaf
ran tox -e ruff, even though tox -e flake8 was fine
filintod 6ae63f4
Merge branch 'main' into filinto/tool-calling
elena-kolevska 1e3baec
add tests to increase coverage in conversation and conversation_helpe…
filintod 924541c
add more information on execute registered tools, also added more tes…
filintod 9dd3bbf
fix test failing on py 1.13. Merge two unit test files per feedback
filintod 5e1bab3
Linter
elena-kolevska bc3dcf0
fix typing issue with UnionType in py3.9
filintod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a vulnerable part of our code, so we need to add at least some basic validation, and probably consider sanitisation for the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let's please add a detailed docstring explaining the vulnerability and giving some suggestions to developers on writing safe functions that validate the LLM input.
I know you said you'd be sending a docs PR, but I think it's important to have this here as well.