Skip to content

Commit 61ebe15

Browse files
Merge pull request #1181 from bibryam/workflow-quickstart
Fixed a bunch of typos
2 parents bd31cf7 + 26e520c commit 61ebe15

File tree

9 files changed

+36
-25
lines changed

9 files changed

+36
-25
lines changed

conversation/csharp/http/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ The terminal console output should look similar to this, where:
4747

4848
<!-- END_STEP -->
4949

50-
2. Stop and clean up application processes.
50+
Stop and clean up application processes.
5151

5252
<!-- STEP
5353
name: Stop multi-app run

conversation/csharp/sdk/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ The terminal console output should look similar to this, where:
4747

4848
<!-- END_STEP -->
4949

50-
2. Stop and clean up application processes.
50+
Stop and clean up application processes.
5151

5252
<!-- STEP
5353
name: Stop multi-app run

conversation/python/http/conversation/app.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
# ------------------------------------------------------------
2+
# Copyright 2025 The Dapr Authors
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
# http://www.apache.org/licenses/LICENSE-2.0
7+
# Unless required by applicable law or agreed to in writing, software
8+
# distributed under the License is distributed on an "AS IS" BASIS,
9+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
10+
# See the License for the specific language governing permissions and
11+
# limitations under the License.
12+
# ------------------------------------------------------------
113
import logging
214
import requests
315
import os
@@ -10,7 +22,6 @@
1022
CONVERSATION_COMPONENT_NAME = 'echo'
1123

1224
input = {
13-
'name': 'echo',
1425
'inputs': [{'content':'What is dapr?'}],
1526
'parameters': {},
1627
'metadata': {}

conversation/python/sdk/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Dapr Conversation API (Python HTTP)
1+
# Dapr Conversation API (Python SDK)
22

33
In this quickstart, you'll send an input to a mock Large Language Model (LLM) using Dapr's Conversation API. This API is responsible for providing one consistent API entry point to talk to underlying LLM providers.
44

@@ -59,7 +59,7 @@ The terminal console output should look similar to this, where:
5959

6060
<!-- END_STEP -->
6161

62-
2. Stop and clean up application processes.
62+
3. Stop and clean up application processes.
6363

6464
<!-- STEP
6565
name: Stop multi-app run

workflows/go/sdk/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ dapr run -f .
6868
4. Stop Dapr workflow with CTRL-C or:
6969

7070
```sh
71-
dapr stop -f .
71+
dapr stop -f .
7272
```
7373

7474
### View workflow output with Zipkin
@@ -83,11 +83,11 @@ launched on running `dapr init`.
8383

8484
### What happened?
8585

86-
When you ran the above comands:
86+
When you ran the above commands:
8787

8888
1. An OrderPayload is made containing one car.
8989
2. A unique order ID for the workflow is generated (in the above example, `b4cb2687-1af0-4f8d-9659-eb6389c07ade`) and the workflow is scheduled.
90-
3. The `NotifyActivity` workflow activity sends a notification saying an order for 10 cars has been received.
90+
3. The `NotifyActivity` workflow activity sends a notification saying an order for 1 car has been received.
9191
4. The `VerifyInventoryActivity` workflow activity checks the inventory data, determines if you can supply the ordered item, and responds with the number of cars in stock.
9292
5. The total cost of the order is 5000, so the workflow will not call the `RequestApprovalActivity` activity.
9393
6. The `ProcessPaymentActivity` workflow activity begins processing payment for order `b4cb2687-1af0-4f8d-9659-eb6389c07ade` and confirms if successful.

workflows/go/sdk/order-processor/models.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package main
33
type OrderPayload struct {
44
ItemName string `json:"item_name"`
55
TotalCost int `json:"total_cost"`
6-
Quantity int `json:"quanity"`
6+
Quantity int `json:"quantity"`
77
}
88

99
type OrderResult struct {
@@ -13,13 +13,13 @@ type OrderResult struct {
1313
type InventoryItem struct {
1414
ItemName string `json:"item_name"`
1515
PerItemCost int `json:"per_item_cost"`
16-
Quantity int `json:"quanity"`
16+
Quantity int `json:"quantity"`
1717
}
1818

1919
type InventoryRequest struct {
2020
RequestID string `json:"request_id"`
2121
ItemName string `json:"item_name"`
22-
Quantity int `json:"quanity"`
22+
Quantity int `json:"quantity"`
2323
}
2424

2525
type InventoryResult struct {

workflows/java/sdk/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ cd ..
3535
name: Run order-processor service
3636
expected_stdout_lines:
3737
- '== APP - order-processor == there are now 9 cars left in stock'
38-
- '== APP - order-processor == workflow instance completed, out is: {"processed":true}'
38+
- '== APP - order-processor == Workflow instance completed, out is: {"processed":true}'
3939
expected_stderr_lines:
4040
output_match_mode: substring
4141
background: true
@@ -85,7 +85,7 @@ dapr run -f .
8585
== APP - order-processor == [Thread-0] INFO io.dapr.quickstarts.workflows.activities.UpdateInventoryActivity - Updated inventory for order 'd1bf548b-c854-44af-978e-90c61ed88e3c': there are now 9 cars left in stock
8686
== APP - order-processor == there are now 9 cars left in stock
8787
== APP - order-processor == [Thread-0] INFO io.dapr.quickstarts.workflows.activities.NotifyActivity - Order completed! : d1bf548b-c854-44af-978e-90c61ed88e3c
88-
== APP - order-processor == workflow instance completed, out is: {"processed":true}
88+
== APP - order-processor == Workflow instance completed, out is: {"processed":true}
8989
```
9090

9191
4. Stop Dapr workflow with CTRL-C or:

workflows/java/sdk/order-processor/src/main/java/io/dapr/quickstarts/workflows/WorkflowConsoleApp.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* distributed under the License is distributed on an "AS IS" BASIS,
99
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1010
* See the License for the specific language governing permissions and
11-
limitations under the License.
11+
* limitations under the License.
1212
*/
1313

1414
package io.dapr.quickstarts.workflows;
@@ -73,22 +73,22 @@ private static void executeWorkflow(DaprWorkflowClient workflowClient, Inventory
7373
System.out.println("==========Begin the purchase of item:==========");
7474
String itemName = inventory.getName();
7575
int orderQuantity = inventory.getQuantity();
76-
int totalcost = orderQuantity * inventory.getPerItemCost();
76+
int totalCost = orderQuantity * inventory.getPerItemCost();
7777
OrderPayload order = new OrderPayload();
7878
order.setItemName(itemName);
7979
order.setQuantity(orderQuantity);
80-
order.setTotalCost(totalcost);
80+
order.setTotalCost(totalCost);
8181
System.out.println("Starting order workflow, purchasing " + orderQuantity + " of " + itemName);
8282

8383
String instanceId = workflowClient.scheduleNewWorkflow(OrderProcessingWorkflow.class, order);
84-
System.out.printf("scheduled new workflow instance of OrderProcessingWorkflow with instance ID: %s%n",
84+
System.out.printf("Scheduled new workflow instance of OrderProcessingWorkflow with instance ID: %s%n",
8585
instanceId);
8686

8787
try {
8888
workflowClient.waitForInstanceStart(instanceId, Duration.ofSeconds(10), false);
89-
System.out.printf("workflow instance %s started%n", instanceId);
89+
System.out.printf("Workflow instance %s started%n", instanceId);
9090
} catch (TimeoutException e) {
91-
System.out.printf("workflow instance %s did not start within 10 seconds%n", instanceId);
91+
System.out.printf("Workflow instance %s did not start within 10 seconds%n", instanceId);
9292
return;
9393
}
9494

@@ -97,13 +97,13 @@ private static void executeWorkflow(DaprWorkflowClient workflowClient, Inventory
9797
Duration.ofSeconds(30),
9898
true);
9999
if (workflowStatus != null) {
100-
System.out.printf("workflow instance completed, out is: %s%n",
100+
System.out.printf("Workflow instance completed, out is: %s%n",
101101
workflowStatus.getSerializedOutput());
102102
} else {
103-
System.out.printf("workflow instance %s not found%n", instanceId);
103+
System.out.printf("Workflow instance %s not found%n", instanceId);
104104
}
105105
} catch (TimeoutException e) {
106-
System.out.printf("workflow instance %s did not complete within 30 seconds%n", instanceId);
106+
System.out.printf("Workflow instance %s did not complete within 30 seconds%n", instanceId);
107107
}
108108

109109
}
@@ -112,12 +112,12 @@ private static InventoryItem prepareInventoryAndOrder() {
112112
// prepare 10 cars in inventory
113113
InventoryItem inventory = new InventoryItem();
114114
inventory.setName("cars");
115-
inventory.setPerItemCost(50000);
115+
inventory.setPerItemCost(5000);
116116
inventory.setQuantity(10);
117117
DaprClient daprClient = new DaprClientBuilder().build();
118118
restockInventory(daprClient, inventory);
119119

120-
// prepare order for 10 cars
120+
// prepare order for 1 car
121121
InventoryItem order = new InventoryItem();
122122
order.setName("cars");
123123
order.setPerItemCost(5000);

workflows/javascript/sdk/order-processor/orderProcessingWorkflow.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ export const orderProcessingWorkflow: TWorkflow = async function* (ctx: Workflow
127127
}
128128

129129
const orderCompletedNotification: OrderNotification = {
130-
message: `order ${orderId} processed successfully!`,
130+
message: `Order ${orderId} processed successfully!`,
131131
};
132132
yield ctx.callActivity(notifyActivity, orderCompletedNotification);
133133

0 commit comments

Comments
 (0)